linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use
@ 2023-09-28 14:56 nicolas.ferre
  2023-10-06  8:15 ` claudiu beznea
  0 siblings, 1 reply; 2+ messages in thread
From: nicolas.ferre @ 2023-09-28 14:56 UTC (permalink / raw)
  To: linux-arm-kernel, Claudiu Beznea, jerry.ray
  Cc: Alexandre Belloni, linux-kernel

From: Nicolas Ferre <nicolas.ferre@microchip.com>

TDES doesn't probe because of lack of DMA channels left on this
controller. As we don't need TDES HW engine, we prefer to keep DMA
channels for other usage.
Disable TDES for this board.

Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Hi,

Tell me what you think about this move. I think it makes sense but tell me if
application could suffer from this lack of TDES engine.

Regards,
  Nicolas

 arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
index c287b03d768b..fddd786f8483 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
@@ -284,6 +284,10 @@ timer1: timer@1 {
 	};
 };
 
+&tdes {
+	status = "disabled";
+};
+
 &usb0 {	/* USB Device port with VBUS detection. */
 	atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use
  2023-09-28 14:56 [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use nicolas.ferre
@ 2023-10-06  8:15 ` claudiu beznea
  0 siblings, 0 replies; 2+ messages in thread
From: claudiu beznea @ 2023-10-06  8:15 UTC (permalink / raw)
  To: nicolas.ferre, linux-arm-kernel, jerry.ray
  Cc: Alexandre Belloni, linux-kernel

Hi, Nicolas, Jerry,

On 28.09.2023 17:56, nicolas.ferre@microchip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> TDES doesn't probe because of lack of DMA channels left on this
> controller. As we don't need TDES HW engine, we prefer to keep DMA
> channels for other usage.
> Disable TDES for this board.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> Hi,
> 
> Tell me what you think about this move. I think it makes sense but tell me if
> application could suffer from this lack of TDES engine.

It anyway fails to probe. I have nothing against unless its probing could
be fixed. Jerry, are you good with applying this?

Thank you,
Claudiu Beznea

> 
> Regards,
>   Nicolas
> 
>  arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> index c287b03d768b..fddd786f8483 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> @@ -284,6 +284,10 @@ timer1: timer@1 {
>  	};
>  };
>  
> +&tdes {
> +	status = "disabled";
> +};
> +
>  &usb0 {	/* USB Device port with VBUS detection. */
>  	atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
>  	pinctrl-names = "default";

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-06  8:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 14:56 [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use nicolas.ferre
2023-10-06  8:15 ` claudiu beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).