Re: [PATCH v2 19/28] dt-bindings: pinctrl: renesas: set additionalProperties: false

claudiu beznea
2023-10-03T03:58:18Z

On 02.10.2023 17:50, Rob Herring wrote:
> On Fri, Sep 29, 2023 at 08:39:06AM +0300, Claudiu wrote:
>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>
>> Set additionalProperties: false.
>>
>> Suggested-by: Rob Herring <robh@kernel.org>
>
> I did?

It is what I've understood from this:

https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230912045157.177966-30-claudiu.beznea.uj@bp.renesas.com/

>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>> ---
>>
>> Changes in v2:
>> - this patch is new in v2 and added as suggested by Rob
>>
>> .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
>> index 4782f96feb7e..eb726770f571 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
>> @@ -106,8 +106,7 @@ additionalProperties:
>> line-name: true
>>
>> - type: object
>> - additionalProperties:
>> - $ref: "#/additionalProperties/anyOf/0"
>> + additionalProperties: false
>
> With no properties defined, this only allows an empty node which is
> probably not what you want. It's the other anyOf entry that needed it,
> but I already sent a fix which Linus applied.

Thanks!

>
> Rob