Re: [PATCH v2 20/28] dt-bindings: pinctrl: renesas: document RZ/G3S SoC

Conor Dooley
2023-09-29T14:07:49Z

[-- Attachment #1.1: Type: text/plain, Size: 2694 bytes --]

On Fri, Sep 29, 2023 at 08:39:07AM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Add documentation for pin controller found on RZ/G3S (R9A08G045) SoC.
> Compared with RZ/G2{L,UL} RZ/G3S has 82 general-purpose IOs, no slew
> rate and output impedance support and more values for drive strength
> which needs to be expressed in microamp.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>
> Changes in v2:
> - defined drive-strength-microamp as general and make if/then schema to
> not allow specific properties depending on compatible
>
> .../pinctrl/renesas,rzg2l-pinctrl.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> index eb726770f571..86228ba69aab 100644
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> @@ -25,6 +25,7 @@ properties:
> - enum:
> - renesas,r9a07g043-pinctrl # RZ/G2UL{Type-1,Type-2} and RZ/Five
> - renesas,r9a07g044-pinctrl # RZ/G2{L,LC}
> + - renesas,r9a08g045-pinctrl # RZ/G3S
>
> - items:
> - enum:
> @@ -78,6 +79,21 @@ additionalProperties:
> - $ref: pincfg-node.yaml#
> - $ref: pinmux-node.yaml#
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a08g045-pinctrl
> + then:
> + properties:
> + drive-strength: false
> + output-impedance-ohms: false
> + slew-rate: false
> + else:
> + properties:
> + drive-strength-microamp: false
> +
> description:
> Pin controller client devices use pin configuration subnodes (children
> and grandchildren) for desired pin configuration.
> @@ -92,6 +108,10 @@ additionalProperties:
> pins: true
> drive-strength:
> enum: [ 2, 4, 8, 12 ]
> + drive-strength-microamp:
> + enum: [ 1900, 2200, 4000, 4400, 4500, 4700, 5200, 5300, 5700,
> + 5800, 6000, 6050, 6100, 6550, 6800, 7000, 8000, 9000,
> + 10000 ]
> output-impedance-ohms:
> enum: [ 33, 50, 66, 100 ]
> power-source:
> --
> 2.39.2
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]