From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39C46E728C4 for ; Fri, 29 Sep 2023 16:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cjpvt4TqhFB46aYFLMbjZooJAzUadDF5+tzihYNa9Cs=; b=VAJqNeje3nxfr3 IznZRemjKNGwjAAgZ1yhlTxvz+Kc4iHSA2M0UBI6htKKqOG96u0bVqUeAeqj/ACppaP33wXEVngKi ap34Q3gNs/QAMHLnE2Zc4upU3M0hG0SgogrUtJjNF3DBnRUrUfnp3O8Kw1x27WKthEt2jqwQIABEt KJHxiCwQPDQk+U1eLq+yF5Qieg8O35ZzXfPJpBWnCtlF7yWpYLfa9hMGx8vkXtHzhDxo9ZJTiASIT PtDByAm8DvASAl97+R2EyH9R4ZxSPgFqoLjzjaEMP8ahxb/UJIVcDw/nxugVOv3Pq6WppuxIAcWhM r2opBaV0tfHBDHKkYRrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmFvj-008FRM-1r; Fri, 29 Sep 2023 16:01:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmFvf-008FQY-3B for linux-arm-kernel@lists.infradead.org; Fri, 29 Sep 2023 16:01:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D9A91FB; Fri, 29 Sep 2023 09:01:56 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 752033F59C; Fri, 29 Sep 2023 09:01:16 -0700 (PDT) Date: Fri, 29 Sep 2023 17:01:14 +0100 From: Sudeep Holla To: Will Deacon Cc: Oza Pawandeep , catalin.marinas@arm.com, Sudeep Holla , rafael@kernel.org, lenb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v8] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer Message-ID: <20230929160114.eq5omxyauu27two7@bogus> References: <20230918172140.2825357-1-quic_poza@quicinc.com> <20230929150459.GA30623@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230929150459.GA30623@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230929_090124_122068_E655504D X-CRM114-Status: GOOD ( 27.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 29, 2023 at 04:04:59PM +0100, Will Deacon wrote: > On Mon, Sep 18, 2023 at 10:21:40AM -0700, Oza Pawandeep wrote: > > Arm=AE Functional Fixed Hardware Specification defines LPI states, > > which provide an architectural context loss flags field that can > > be used to describe the context that might be lost when an LPI > > state is entered. > > = > > - Core context Lost > > - General purpose registers. > > - Floating point and SIMD registers. > > - System registers, include the System register based > > - generic timer for the core. > > - Debug register in the core power domain. > > - PMU registers in the core power domain. > > - Trace register in the core power domain. > > - Trace context loss > > - GICR > > - GICD > > = > > Qualcomm's custom CPUs preserves the architectural state, > > including keeping the power domain for local timers active. > > when core is power gated, the local timers are sufficient to > > wake the core up without needing broadcast timer. > > = > > The patch fixes the evaluation of cpuidle arch_flags, and moves only to > > broadcast timer if core context lost is defined in ACPI LPI. > > = > > Fixes: a36a7fecfe607 ("Add support for Low Power Idle(LPI) states") > > Reviewed-by: Sudeep Holla > > Acked-by: Rafael J. Wysocki > > Signed-off-by: Oza Pawandeep > > --- > > = > > Notes: > > Will/Catalin: Rafael has acked and he prefers to take it via arm64 = tree > > = > > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acp= i.h > > index 4d537d56eb84..269d21209723 100644 > > --- a/arch/arm64/include/asm/acpi.h > > +++ b/arch/arm64/include/asm/acpi.h > > @@ -9,6 +9,7 @@ > > #ifndef _ASM_ACPI_H > > #define _ASM_ACPI_H > > = > > +#include > > #include > > #include > > #include > > @@ -44,6 +45,23 @@ > > = > > #define ACPI_MADT_GICC_TRBE (offsetof(struct acpi_madt_generic_interr= upt, \ > > trbe_interrupt) + sizeof(u16)) > > +/* > > + * Arm=AE Functional Fixed Hardware Specification Version 1.2. > > + * Table 2: Arm Architecture context loss flags > > + */ > > +#define CPUIDLE_CORE_CTXT BIT(0) /* Core context Lost */ > > + > > +static __always_inline void _arch_update_idle_state_flags(u32 arch_fla= gs, > > + unsigned int *sflags) > = > Why can't this just be 'static inline'? > = > > +{ > > + if (arch_flags & CPUIDLE_CORE_CTXT) > > + *sflags |=3D CPUIDLE_FLAG_TIMER_STOP; > > +} > > +#define arch_update_idle_state_flags _arch_update_idle_state_flags > = > Usually, the function and the macro have the same name for this pattern, > so I think it would be more consistent to drop the leading underscore > from the C function name. > Sorry that's me telling him looking at some other example I think. I don't have a strong opinion, just referred examples doing this way I guess. Oza, please check it to as it was before I requested this. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel