From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D089E728CA for ; Fri, 29 Sep 2023 16:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DfE/8D6ky/S4lpNhvRHHfdW8AzYTSQ3qIuKIZeN12gE=; b=ZKhVGooXWPBQhp E3iR+kPsqVM5sszKl6eDKOwpfuCmbBGYD9PlX1WUCIHqiQ/2FVECwddlKLCsa+EqGgM9aBeFA81LO h6cOd/qbSprPrLXw+qKw6ql1NUowDONjopCt5GFoDR35LHJdFgtkYch2vXOQBICwyikrGuptH5B8S X+3bR9U9+R3ELTTuY22nRb1MQro5IV6Vii9I7SURqJ6HYEEg9gikEwofMgtahjW8REWcFnQjZVD8I vdusdbMqKGL8tUyxLK9/5K58HBF297tZgdKj3e6gefHMWFwTl6OmOXJ+HWFA/OGVf+iLwp3esNrZw jxzBv5ZdvLLAWWMsImhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmGfc-008JB5-11; Fri, 29 Sep 2023 16:48:52 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qmGfW-008JAO-1r for linux-arm-kernel@lists.infradead.org; Fri, 29 Sep 2023 16:48:50 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id F27EE60003; Fri, 29 Sep 2023 16:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696006121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SyMS/5qoRAxmb7CrTM+yM7HBi388BYrsqn7VTrt5ppo=; b=T66uYhvYkIXQAOmAzHmZl2r02yXOHjqB9pMo+eTUk/a6EUEWjb4F/MRO4OHTYBoEC2myNS WBvYpKjqFcI6rXTNzmtLh7TcliTWMXDXnSl1kPAew0BIW6Gaq/KCe0uaQnyw/wwSzxZh7l lDpWWsucV0p1wWWFWeQ3q8QFb9Uka8u+qi8b6B5ArVnJYBYQPEl0aFsgR7lQgaDzmOsuNq AhHkpTmOyTyElZ/sKLIQYXlW685mFPinerMcqvsJjRnC9/Ehq6aAECchMXJTASB6Zwxzuq EIQxfjjk+kckagid/vi3YLiUFoiPUsD9qkLNrSfET1+Q7LjffRr3VhhZ0/+SlA== Date: Fri, 29 Sep 2023 18:48:35 +0200 From: Luca Ceresoli To: Lucas Stach Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI Message-ID: <20230929184835.1de69182@booty> In-Reply-To: <20230928125536.1782715-1-l.stach@pengutronix.de> References: <20230928125536.1782715-1-l.stach@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230929_094847_145972_824BC50D X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lucas, On Thu, 28 Sep 2023 14:55:35 +0200 Lucas Stach wrote: > Add binding for the i.MX8MP HDMI parallel video interface block. > > Signed-off-by: Lucas Stach > Reviewed-by: Laurent Pinchart > --- > .../display/imx/fsl,imx8mp-hdmi-pvi.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > new file mode 100644 > index 000000000000..df29006b4090 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,imx8mp-hdmi-pvi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8MP HDMI Parallel Video Interface > + > +maintainers: > + - Lucas Stach > + > +description: | > + The HDMI parallel video interface is a timing and sync generator block in the > + i.MX8MP SoC, that sits between the video source and the HDMI TX controller. > + > +properties: > + compatible: > + const: fsl,imx8mp-hdmi-pvi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input from the LCDIF controller. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output to the HDMI TX controller. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - interrupts Sure it is required? In the imx8mp.dtsi I have, which comes for a patch you sent previously, there is no 'interrupts' property, and HDMI works. > + - power-domains > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + display-bridge@32fc4000 { > + compatible = "fsl,imx8mp-hdmi-pvi"; > + reg = <0x32fc4000 0x40>; The device has up to register 0x40, thus I guess the second value should be 0x44 here. Or maybe 0x100, just to be comfortable. :) Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel