From: Greg KH <gregkh@linuxfoundation.org>
To: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Cc: michal.simek@amd.com, tanmay.shah@amd.com,
sai.krishna.potthuri@amd.com, nava.kishore.manne@amd.com,
ben.levinsky@amd.com, dhaval.r.shah@amd.com, marex@denx.de,
robh@kernel.org, arnd@arndb.de, izhar.ameer.shaikh@amd.com,
ruanjinjie@huawei.com, mathieu.poirier@linaro.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] drivers: soc: xilinx: add check for platform
Date: Sat, 30 Sep 2023 09:17:59 +0200 [thread overview]
Message-ID: <2023093034-spiny-diagnoses-3da7@gregkh> (raw)
In-Reply-To: <20230929105558.11893-4-jay.buddhabhatti@amd.com>
On Fri, Sep 29, 2023 at 03:55:54AM -0700, Jay Buddhabhatti wrote:
> Some error event IDs for Versal and Versal NET are different.
> Both the platforms should access their respective error event
> IDs so use sub_family_code to check for platform and check
> error IDs for respective platforms. The family code is passed
> via platform data to avoid platform detection again.
> Platform data is setup when even driver is registered.
>
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
> ---
> drivers/firmware/xilinx/zynqmp.c | 2 +-
> drivers/soc/xilinx/xlnx_event_manager.c | 25 ++++++++++++++++++++-----
> include/linux/firmware/xlnx-zynqmp.h | 16 ++++++++++++----
> 3 files changed, 33 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 5f40288f69a9..6583efa9ac48 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -2019,7 +2019,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
> np = of_find_compatible_node(NULL, NULL, "xlnx,versal");
> if (np) {
> em_dev = platform_device_register_data(&pdev->dev, "xlnx_event_manager",
> - -1, NULL, 0);
> + -1, &pm_sub_family_code, 4);
> if (IS_ERR(em_dev))
> dev_err_probe(&pdev->dev, PTR_ERR(em_dev), "EM register fail with error\n");
> }
> diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c
> index 38cfc161a713..8074ded7b39c 100644
> --- a/drivers/soc/xilinx/xlnx_event_manager.c
> +++ b/drivers/soc/xilinx/xlnx_event_manager.c
> @@ -23,6 +23,7 @@ static DEFINE_PER_CPU_READ_MOSTLY(int, cpu_number1);
>
> static int virq_sgi;
> static int event_manager_availability = -EACCES;
> +static u32 pm_sub_family_code;
Why is this not a per-device variable? Global variables like this for
drivers are almost always wrong.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-30 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 10:55 [PATCH 0/7] update for versal net platform Jay Buddhabhatti
2023-09-29 10:55 ` [PATCH 1/7] firmware: xilinx: Update firmware call interface to support additional arg Jay Buddhabhatti
2023-09-29 10:55 ` [PATCH 2/7] firmware: xilinx: Expand feature check to support all PLM modules Jay Buddhabhatti
2023-09-29 10:55 ` [PATCH 3/7] drivers: soc: xilinx: add check for platform Jay Buddhabhatti
2023-09-30 7:17 ` Greg KH [this message]
2023-10-02 6:09 ` Michal Simek
2023-10-02 6:20 ` Greg KH
2023-10-02 8:12 ` Michal Simek
2023-09-29 10:55 ` [PATCH 4/7] firmware: xilinx: Register event manager driver Jay Buddhabhatti
2023-09-29 10:55 ` [PATCH 5/7] drivers: soc: xilinx: Fix error message on SGI registration failure Jay Buddhabhatti
2023-09-29 10:55 ` [PATCH 6/7] firmware: zynqmp: Add support to handle IPI CRC failure Jay Buddhabhatti
2023-09-29 10:55 ` [PATCH 7/7] drivers: soc: xilinx: update maintainer of event manager driver Jay Buddhabhatti
2023-09-30 7:17 ` Greg KH
2023-10-02 6:10 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023093034-spiny-diagnoses-3da7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ben.levinsky@amd.com \
--cc=dhaval.r.shah@amd.com \
--cc=izhar.ameer.shaikh@amd.com \
--cc=jay.buddhabhatti@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=nava.kishore.manne@amd.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sai.krishna.potthuri@amd.com \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).