From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8656BE7735F for ; Sat, 30 Sep 2023 07:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j2zPwr8phW7Ou+aTuaimM4a88bZ4peCmc6fJ6PHRgNw=; b=eAoCvO/udr4VNm vVRdxWbnH9GkktHUBGxkVlnheRBHgrLpoHF0nrULlN2CUA7Muf/RDZG/zDhLYnjUtKRimImkqfcL2 DGdiF/nVSF7Eoals+szASOz3vLtR6wm3bW+2SxuQIbuj5N+RtxXFc77icZ7WE4/dClTtwddwFWHOY pfsPDZxUUulqeA/UuJvZ3td96notnRZjFxukRDjqSjvE7cW5j1S8+tpA/MkBVvybXQSvELNdjPYJl nh4MIdIFO3KThYgsmi9Q9K5IepFfE1bmvuMJRfR3GJonn91DpZ2rdB2J480rcjEn/SL6aBqvsDCDj IRhp5JiSJDhefVGHF5VQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmUEu-0096m4-1N; Sat, 30 Sep 2023 07:18:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qmUEr-0096kn-01 for linux-arm-kernel@lists.infradead.org; Sat, 30 Sep 2023 07:18:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 08A2760A6E; Sat, 30 Sep 2023 07:18:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23D8BC433C8; Sat, 30 Sep 2023 07:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696058282; bh=RJOESfC9EnjjXjWIGXaZMW/z4qLvxv9GJxGbs9/30f8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m2tLpaUxc1PSpipSv/Ozp8yrRKKkHG+s3G79lMPB4qJMAe+n69E6y+aewuWbFVkWM sCBRogduM+nQ3rAJ04Wn8Lh+SKIhhu2ISjmiyDAo7/rJWFNFkz4XLGZjZR4KdR9KuZ 5YJ2OYXyqEOwfI4Rv8tposOnIhfDWZI9+PU17kG4= Date: Sat, 30 Sep 2023 09:17:59 +0200 From: Greg KH To: Jay Buddhabhatti Cc: michal.simek@amd.com, tanmay.shah@amd.com, sai.krishna.potthuri@amd.com, nava.kishore.manne@amd.com, ben.levinsky@amd.com, dhaval.r.shah@amd.com, marex@denx.de, robh@kernel.org, arnd@arndb.de, izhar.ameer.shaikh@amd.com, ruanjinjie@huawei.com, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/7] drivers: soc: xilinx: add check for platform Message-ID: <2023093034-spiny-diagnoses-3da7@gregkh> References: <20230929105558.11893-1-jay.buddhabhatti@amd.com> <20230929105558.11893-4-jay.buddhabhatti@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230929105558.11893-4-jay.buddhabhatti@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230930_001809_094322_6D380A4C X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 29, 2023 at 03:55:54AM -0700, Jay Buddhabhatti wrote: > Some error event IDs for Versal and Versal NET are different. > Both the platforms should access their respective error event > IDs so use sub_family_code to check for platform and check > error IDs for respective platforms. The family code is passed > via platform data to avoid platform detection again. > Platform data is setup when even driver is registered. > > Signed-off-by: Jay Buddhabhatti > --- > drivers/firmware/xilinx/zynqmp.c | 2 +- > drivers/soc/xilinx/xlnx_event_manager.c | 25 ++++++++++++++++++++----- > include/linux/firmware/xlnx-zynqmp.h | 16 ++++++++++++---- > 3 files changed, 33 insertions(+), 10 deletions(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 5f40288f69a9..6583efa9ac48 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -2019,7 +2019,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > np = of_find_compatible_node(NULL, NULL, "xlnx,versal"); > if (np) { > em_dev = platform_device_register_data(&pdev->dev, "xlnx_event_manager", > - -1, NULL, 0); > + -1, &pm_sub_family_code, 4); > if (IS_ERR(em_dev)) > dev_err_probe(&pdev->dev, PTR_ERR(em_dev), "EM register fail with error\n"); > } > diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c > index 38cfc161a713..8074ded7b39c 100644 > --- a/drivers/soc/xilinx/xlnx_event_manager.c > +++ b/drivers/soc/xilinx/xlnx_event_manager.c > @@ -23,6 +23,7 @@ static DEFINE_PER_CPU_READ_MOSTLY(int, cpu_number1); > > static int virq_sgi; > static int event_manager_availability = -EACCES; > +static u32 pm_sub_family_code; Why is this not a per-device variable? Global variables like this for drivers are almost always wrong. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel