From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01DF7E7735A for ; Sat, 30 Sep 2023 06:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J3iXBNiXVG+9uZX0nklPgXSS3Lm8QBQ/OaBfBP7oZpg=; b=lJrcF7yo2jCsw9 3oG+3pTtd/deEipUw6pzQvz6guXscYS+3iYxs4QttMfubmCjcfbSbxDzu+5lqqVMIHLKc8ePBPRsf qfAFqSXnycO4HdXavHAQxLOn8Yb09miwhDQnS3DXN83qozrBLGi8OFjLyL2M0KalxM87iaI+peRfK xy0btW0MFiCdEenZRGWGQ8PaQa5IRCHX0etXoV3+pz2yhPsakl1lmbJ3DPFiKtZ8hDUhUfi3n5WmJ FAm682rtpiG7C1DZ04WC5R6iurxsiPUY1r1jJeEiiHDg87QhHNVYPXSNxYT0/86iNaDj6n7Br/3vF 1J4+wr2kdOjCP8VNtWHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmTAO-0093Ex-2d; Sat, 30 Sep 2023 06:09:28 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qmTAM-0093Dr-1R for linux-arm-kernel@lists.infradead.org; Sat, 30 Sep 2023 06:09:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C934FCE2315; Sat, 30 Sep 2023 06:09:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2656CC433C7; Sat, 30 Sep 2023 06:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696054162; bh=uvjHAVtyz+cMLlBpiml8y8WpVPimcnEoijVRbGSv7y0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YyRBlWndR3KwVIYMarncmB/ymR7JLJrQUvl56+M+guaafrMTYE6eV9jnmINKz1Ngd mG2z7FNLyoFAkJfsX7netdXC6W9z6m+MOIPOY+TYgwcq12c5WGHsbQcBJT/2AvLXcJ ySpfKlnuIVN74VanHAw/DkBr+ZnInv5wVMyFTt3Q= Date: Sat, 30 Sep 2023 08:09:19 +0200 From: Greg KH To: Nuno Das Neves Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs Message-ID: <2023093057-eggplant-reshoot-8513@gregkh> References: <1696010501-24584-1-git-send-email-nunodasneves@linux.microsoft.com> <1696010501-24584-14-git-send-email-nunodasneves@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1696010501-24584-14-git-send-email-nunodasneves@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230929_230926_725172_3AF6282D X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > These must be in uapi because they will be used in the mshv ioctl API. > > Version numbers for each file: > hvhdk.h 25212 > hvhdk_mini.h 25294 > hvgdk.h 25125 > hvgdk_mini.h 25294 what are version numbers? > These are unstable interfaces and as such must be compiled independently > from published interfaces found in hyperv-tlfs.h. uapi files can NOT be unstable, that's the opposite of an api :( > Signed-off-by: Nuno Das Neves > Acked-by: Wei Liu > --- > include/uapi/hyperv/hvgdk.h | 41 + > include/uapi/hyperv/hvgdk_mini.h | 1076 ++++++++++++++++++++++++ > include/uapi/hyperv/hvhdk.h | 1342 ++++++++++++++++++++++++++++++ > include/uapi/hyperv/hvhdk_mini.h | 160 ++++ > 4 files changed, 2619 insertions(+) > create mode 100644 include/uapi/hyperv/hvgdk.h > create mode 100644 include/uapi/hyperv/hvgdk_mini.h > create mode 100644 include/uapi/hyperv/hvhdk.h > create mode 100644 include/uapi/hyperv/hvhdk_mini.h > > diff --git a/include/uapi/hyperv/hvgdk.h b/include/uapi/hyperv/hvgdk.h > new file mode 100644 > index 000000000000..9bcbb7d902b2 > --- /dev/null > +++ b/include/uapi/hyperv/hvgdk.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: MIT */ That's usually not a good license for a new uapi .h file, why did you choose this one? > +/* Define connection identifier type. */ > +union hv_connection_id { > + __u32 asu32; > + struct { > + __u32 id:24; > + __u32 reserved:8; > + } __packed u; bitfields will not work properly in uapi .h files, please never do that. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel