From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E0AEE784A4 for ; Mon, 2 Oct 2023 06:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rbIa8OBnX/rWrVTct+vNkuwQKqWHF9i2p0OL2GWulgs=; b=gtqzi3OR7cx+xh DMpyZmuXTWbim6pjlOIRVdK0VlkQTKAT2mje3sHB9EM0OSsudm5Ju2rFEC5BrANcmGOmuYZBz0Eku 2eQrwB+PU6BM/htxs16FqUwXthjJQD3hofSimbxHUu1lYED9MYkeJusYd8/oDGYD28RsfvILXPU68 s6Ti9WeqFJCiJ0du/YJzcqmdV8H7hWjWYZF9N9lup/ryL/FnDEcZowHJPASUFmLpNDse5h+sVkyJK iI8zi+nCDA6btVCGMN8ZTj1P/8vQ2aD4iAOAwUSNTqxHRPYLM8sfylDxWXTnc0N093BcYSziTrhDP G/O5KV1Ngs1IifySjvqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnCHr-00C1Im-0X; Mon, 02 Oct 2023 06:20:11 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnCHo-00C1IA-1g for linux-arm-kernel@lists.infradead.org; Mon, 02 Oct 2023 06:20:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CB5E3B80DC3; Mon, 2 Oct 2023 06:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94388C433C8; Mon, 2 Oct 2023 06:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696227605; bh=ElcpeFJ4rQlE/UqOnsiI3Q6ToiIE7LPVEWkn8Ad4mt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qDyzZZgLha+p/d15wqstnjR/o7FwtLnd5ypq8ozgUJ6E+EMoXB6L6l45zXDCRKwdP sXDoPqv05E8NwgH0Brp5BuyyIASbQ2mCJyQKrcZVAdSSOYIUuseQrNCpvCj1C9inh2 EBvwCgF8csZC9z+b+1asYi7LLnlOgheZzK6iHBEc= Date: Mon, 2 Oct 2023 08:20:03 +0200 From: Greg KH To: Michal Simek Cc: Jay Buddhabhatti , tanmay.shah@amd.com, sai.krishna.potthuri@amd.com, nava.kishore.manne@amd.com, ben.levinsky@amd.com, dhaval.r.shah@amd.com, marex@denx.de, robh@kernel.org, arnd@arndb.de, izhar.ameer.shaikh@amd.com, ruanjinjie@huawei.com, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/7] drivers: soc: xilinx: add check for platform Message-ID: <2023100223-trouble-conjoined-fb51@gregkh> References: <20230929105558.11893-1-jay.buddhabhatti@amd.com> <20230929105558.11893-4-jay.buddhabhatti@amd.com> <2023093034-spiny-diagnoses-3da7@gregkh> <1a38b6bf-00ef-4ada-a9a7-8dff5c3a1934@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1a38b6bf-00ef-4ada-a9a7-8dff5c3a1934@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231001_232008_904204_F49C6365 X-CRM114-Status: GOOD ( 30.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 02, 2023 at 08:09:50AM +0200, Michal Simek wrote: > > > On 9/30/23 09:17, Greg KH wrote: > > On Fri, Sep 29, 2023 at 03:55:54AM -0700, Jay Buddhabhatti wrote: > > > Some error event IDs for Versal and Versal NET are different. > > > Both the platforms should access their respective error event > > > IDs so use sub_family_code to check for platform and check > > > error IDs for respective platforms. The family code is passed > > > via platform data to avoid platform detection again. > > > Platform data is setup when even driver is registered. > > > > > > Signed-off-by: Jay Buddhabhatti > > > --- > > > drivers/firmware/xilinx/zynqmp.c | 2 +- > > > drivers/soc/xilinx/xlnx_event_manager.c | 25 ++++++++++++++++++++----- > > > include/linux/firmware/xlnx-zynqmp.h | 16 ++++++++++++---- > > > 3 files changed, 33 insertions(+), 10 deletions(-) > > > > > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > > > index 5f40288f69a9..6583efa9ac48 100644 > > > --- a/drivers/firmware/xilinx/zynqmp.c > > > +++ b/drivers/firmware/xilinx/zynqmp.c > > > @@ -2019,7 +2019,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > > > np = of_find_compatible_node(NULL, NULL, "xlnx,versal"); > > > if (np) { > > > em_dev = platform_device_register_data(&pdev->dev, "xlnx_event_manager", > > > - -1, NULL, 0); > > > + -1, &pm_sub_family_code, 4); > > > if (IS_ERR(em_dev)) > > > dev_err_probe(&pdev->dev, PTR_ERR(em_dev), "EM register fail with error\n"); > > > } > > > diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c > > > index 38cfc161a713..8074ded7b39c 100644 > > > --- a/drivers/soc/xilinx/xlnx_event_manager.c > > > +++ b/drivers/soc/xilinx/xlnx_event_manager.c > > > @@ -23,6 +23,7 @@ static DEFINE_PER_CPU_READ_MOSTLY(int, cpu_number1); > > > static int virq_sgi; > > > static int event_manager_availability = -EACCES; > > > +static u32 pm_sub_family_code; > > > > Why is this not a per-device variable? Global variables like this for > > drivers are almost always wrong. > > Not sure I get what you mean by per-device. Can you please elaborate on it? It should not be a global variable (i.e. the same for all devices in the system.) > This is the part of firmware infrastructure and there is only one instance > of the driver in the system registered from firmware driver itself. Then that should be fixed. > If this should be done in a generic way then there are much more variables > which should be moved to driver data not just this one. Agreed, they should all be moved there. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel