From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75E88E75445 for ; Tue, 3 Oct 2023 10:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mNTbS4IdRmUS7dE5IIV3W9dS9dDpwXSBhNZ7XKEIanc=; b=PtHRbV2p8KUMCw oxdW/yDMLx4mUrlIPj6+mFIS5ZEYFyI+Iz3oQW16O/FFMVXbtytngX20lJ4u3cW1FlVOzmC7f5T0M 5P22Yg1rwzvnOKiTgZb86oeYWgxfUtzJLtQsFJu/xDxFJzZsce79tRXPB5IB+iMZ90nGjq3ugWGSJ s3EQNN/ibuCTa/mD6HkTOqX7uwtZXwXOEkEr2usO8WH+23w5JsRNopZ4Ag7K7wJukYPv9/PnSgXqM ULh/pCX4fSZQ63AmejCJ7WwS3pwdBm5D0DG8mzM07mjSMgvfW2KixpDfKWaomif3lKtQmbwlYNvYb CAEtyjryGeH70+AdOaCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnciY-00EJTF-1E; Tue, 03 Oct 2023 10:33:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnciV-00EJSP-2U for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 10:33:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 958B8C15; Tue, 3 Oct 2023 03:33:59 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B0133F5A1; Tue, 3 Oct 2023 03:33:19 -0700 (PDT) Date: Tue, 3 Oct 2023 11:33:17 +0100 From: Sudeep Holla To: Nikunj Kela Cc: cristian.marussi@arm.com, robh+dt@kernel.org, Sudeep Holla , Brian Masney , krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc Message-ID: <20231003103317.pjfmf6uisahowmom@bogus> References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230911194359.27547-1-quic_nkela@quicinc.com> <20230911194359.27547-2-quic_nkela@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230911194359.27547-2-quic_nkela@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_033327_859541_AC90A0C0 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 11, 2023 at 12:43:56PM -0700, Nikunj Kela wrote: > Currently, the return from the smc call assumes the completion of > the scmi request. However this may not be true in virtual platforms > that are using hvc doorbell. > Hmm, it is expectation from SMCCC for the fast calls. Is you HVC FID not a fast call. AFAIK, only TOS use yielding calls. Are you using them here ? If not, this must complete when the SMC/HVC returns. We added support for platforms indicating the same via interrupt. I would like to avoid adding this build config. Why does it require polling ? Broken firmware ? I would add a compatible for that. Or if the qcom always wants to do this way, just make it specific to the qcom compatible. I would avoid a config flag as it needs to be always enabled for single image and affects other platforms as well. So please drop this change. If this is absolutely needed, just add additional property which DT maintainers may not like as it is more like a policy or just make it compatible specific. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel