From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 577DDE75449 for ; Tue, 3 Oct 2023 10:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KWaZhAobcmnDJ7EVXvlpQk6ahT8wbe5SgGYe8V8s7mw=; b=n4I1QzNxJ9Co4H ijdXgEFghSUwzRaymkEGAhyrmazVREGf86gPgjNffzdQo6LBBgQiVeY9QNQ1WdgjZdoRm8sBueqvM cU2AZ9SxDa5cCX0cxcqmB/CblHZzTzshrN7GyadEsBzBj5Q5w1nQVQMtZb83WZDCOqeLRQW1NXonY turJccXtkszJX5Z/c2+x5g5wNIZfgmPs3RhTIvoAVkEA3uJPQjdkNWP4QL94E0QofexWCiBiaAC+c aJHMuBMK8SQlnZwK5JtY3lGFrqEihSIUfPv7ngcqmGOWxK4FCb1LgezbkNoFBr8bh0Mjl9roCdOtK RLBwqfk3AaJGnfYN7dIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qncsy-00ELxq-0C; Tue, 03 Oct 2023 10:44:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qncsu-00ELud-0d for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 10:44:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C27DDC15; Tue, 3 Oct 2023 03:44:46 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D69413F5A1; Tue, 3 Oct 2023 03:44:06 -0700 (PDT) Date: Tue, 3 Oct 2023 11:44:04 +0100 From: Sudeep Holla To: Nikunj Kela Cc: cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Message-ID: <20231003104404.o7yxg3y7dn7uhrq4@bogus> References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230911194359.27547-1-quic_nkela@quicinc.com> <20230911194359.27547-4-quic_nkela@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230911194359.27547-4-quic_nkela@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_034412_306796_7CE294B3 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 11, 2023 at 12:43:58PM -0700, Nikunj Kela wrote: > Introduce compatible "qcom,scmi-hvc-shmem" for SCMI smc/hvc > transport channel for Qualcomm virtual platforms. > The compatible mandates a shared memory channel. > > Signed-off-by: Nikunj Kela > Acked-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/firmware/arm,scmi.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 8d54ea768d38..4090240f45b1 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -45,6 +45,9 @@ properties: > - description: SCMI compliant firmware with OP-TEE transport > items: > - const: linaro,scmi-optee > + - description: SCMI compliant firmware with Qualcomm hvc/shmem transport > + items: > + - const: qcom,scmi-hvc-shmem Can it be simply "qcom,scmi-smc" for 2 reasons ? 1. We don't support SMC/HVC without shmem, so what is your argument to add '-shmem' in the compatible here ? 2. The exact conduit(SMC/HVC) used is detected runtime, so I prefer to keep '-smc' instead of '-hvc' in the compatible just to avoid giving an illusion that HVC is the conduit chosen here based on the compatible. It can be true for other reason but I don't want to mislead here by using HVC. > > interrupts: > description: > @@ -320,6 +323,15 @@ allOf: > required: > - linaro,optee-channel-id > > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scmi-hvc-shmem > + then: > + required: > + - shmem > + > examples: > - | > firmware { > -- > 2.17.1 > -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel