From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F0A0E75450 for ; Tue, 3 Oct 2023 11:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hf8WTaTijQ65LNq1tfGe20D0/LnlTJrb06FvGY8B2jI=; b=CtA8U0LSWPQuB1 zgan0bL9Ph64dfxEvh4Li/TeZoqE19dxN19ZoCqlZHK+7UgraZtORTKVQ9LEqoCRTM7S2EaWFEoru OYXPk+hfyzf34brIffo5FZLCjc4M7re4+FmgzWawmzcu9hKbWMwd7YR9LHwc1VOkM2W+0VIW0nR3J CgHFW3+V6JwQdYg+IN8Ia/3vNU/rGp2/lQ+B94VoU7kFA2J+GTfJ9F2V9mwikISaZeY+CKaQMWO+1 oFpD4ekXLAaOURCqwEL7DrnWV/aU3d8GOy7xHjwAwlE1ihOrfKCjt1FKqOMy0cw8i3whQmSF6TqWu 3ClgDCztbaxTDae4gqaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qndbg-00EXPe-2z; Tue, 03 Oct 2023 11:30:28 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qndbc-00EXOX-0h for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 11:30:26 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 393BUHjf096934; Tue, 3 Oct 2023 06:30:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696332617; bh=N5ZztSjzf9OfIIVeBtDwEBQrwZRy6ntL0AONwTZqnXw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=mIM4nmepfnBsiBPoQGZMKtED0Id5K9QGTYM5QBcs19bqIrdApWtG8xJ9TF66WyjlU KWKdEghFAJU71LY0ZTk1QiDESv7KVi9PDdDx8Fnzo2vYigwzZrqHQ0uUoNvixrV5rY IRSzIAv3YY1oJC/7XjsuxaJ6544GwKzq57tGAWLo= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 393BUHf9015649 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Oct 2023 06:30:17 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 3 Oct 2023 06:30:17 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 3 Oct 2023 06:30:17 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 393BUHiB023243; Tue, 3 Oct 2023 06:30:17 -0500 Date: Tue, 3 Oct 2023 06:30:17 -0500 From: Nishanth Menon To: Ayush Singh CC: , , , , , , , , , , , Subject: Re: [PATCH v6 1/3] dt-bindings: Add beaglecc1352 Message-ID: <20231003113017.z3yyjscvvinwnyy7@putdown> References: <20231002182454.211165-1-ayushdevel1325@gmail.com> <20231002182454.211165-2-ayushdevel1325@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231002182454.211165-2-ayushdevel1325@gmail.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_043024_340669_EB200378 X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23:54-20231002, Ayush Singh wrote: > Add DT bindings for BeaglePlay CC1352 co-processor. > > The BeaglePlay has a CC1352 co-processor. This co-processor is connected > to the main AM62 (running Linux) over UART. In the BeagleConnect > Technology, CC1352 is responsible for handling 6LoWPAN communication > with beagleconnect freedom nodes as well as their discovery > > This commit adds net/ti,cc1352p7. It is used by gb-beagleplay greybus > driver. > > Signed-off-by: Ayush Singh > --- > .../devicetree/bindings/net/ti,cc1352p7.yaml | 48 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > new file mode 100644 > index 000000000000..57bc2c43e5b1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments Simplelink CC1352P7 wireless MCU > + > +description: > + The cc1352p7 mcu can be connected via SPI or UART. > + > +maintainers: > + - Ayush Singh > + > +properties: > + compatible: > + const: ti,cc1352p7 > + > + clocks: > + maxItems: 2 I would suggest clock-names and description for it. > + > + reset-gpios: > + maxItems: 1 > + > + power-gpios: > + maxItems: 3 > + description: > + The device has three power rails that are exposed on external pins VDDS, > + VDDR and DCOUPL. Shouldn't these be regulators? The power rails are input to the MCU, correct? The properties should be something like: vdds-supply vddr-supply dcoupl-supply ? (not sure what dcoupl is, but description should provide that info). the gpio controls for those can be modelled by regulator-gpio ? > + > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + serial { > + mcu { > + compatible = "ti,cc1352p7"; > + clocks = <&sclk_hf 0>, <&sclk_lf 25>; > + reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>; > + power-gpios = <&pio 1 GPIO_ACTIVE_HIGH>, <&pio 2 GPIO_ACTIVE_HIGH>, <&pio 3 GPIO_ACTIVE_HIGH>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 37b9626ee654..5467669d7963 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8969,6 +8969,12 @@ F: drivers/staging/greybus/sdio.c > F: drivers/staging/greybus/spi.c > F: drivers/staging/greybus/spilib.c > > +GREYBUS BEAGLEPLAY DRIVERS > +M: Ayush Singh > +L: greybus-dev@lists.linaro.org (moderated for non-subscribers) > +S: Maintained > +F: Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > + > GREYBUS SUBSYSTEM > M: Johan Hovold > M: Alex Elder > -- > 2.41.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel