From: Nishanth Menon <nm@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Nitin Yadav <n-yadav@ti.com>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh+dt@kernel.org>, <conor+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <catalin.marinas@arm.com>,
<will@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] arm64: dts: ti: Add GPMC support for AM62x LP SK
Date: Wed, 4 Oct 2023 07:07:49 -0500 [thread overview]
Message-ID: <20231004120749.p253uqn43s47qjud@blend> (raw)
In-Reply-To: <34845445-91d7-1cb9-3a75-bc591c6c1560@ti.com>
On 14:27-20231004, Roger Quadros wrote:
>
>
> On 4.10.2023 14.12, Nitin Yadav wrote:
> > Add gpmc0 and elm0 nodes in k3-am62-main. Add GPMC0_CFG and
> > GPMC0_DATA entry in cbass_main node.
> >
> > Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> > ---
> > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
> > arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
> > 2 files changed, 31 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index ac760d9b831d..f854369dfc27 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -965,4 +965,33 @@ mcasp2: audio-controller@2b20000 {
> > power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> > status = "disabled";
> > };
>
> Please add blank line here.
>
> > + gpmc0: memory-controller@3b000000 {
> > + compatible = "ti,am64-gpmc";
> > + reg = <0x00 0x03b000000 0x00 0x400>,
> > + <0x00 0x050000000 0x00 0x8000000>;
> > + reg-names = "cfg", "data";
> > + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&k3_clks 80 0>;
> > + clock-names = "fck";
> > + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> > + gpmc,num-cs = <3>;
> > + gpmc,num-waitpins = <2>;
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + status = "disabled";
Document why disabled by default.
> > + };
> > +
> > + elm0: ecc@25010000 {
> > + compatible = "ti,am3352-elm";
> > + reg = <0x00 0x25010000 0x00 0x2000>;
> > + interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&k3_clks 54 0>;
> > + clock-names = "fck";
> > + power-domains = <&k3_pds 54 TI_SCI_PD_EXCLUSIVE>;
> > + status = "disabled";
Document why disabled by default.
> > + };
> > };
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62.dtsi b/arch/arm64/boot/dts/ti/k3-am62.dtsi
> > index f1e15206e1ce..b9b1e522d74c 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62.dtsi
> > @@ -77,6 +77,8 @@ cbass_main: bus@f0000 {
> > <0x00 0x70000000 0x00 0x70000000 0x00 0x00010000>, /* OCSRAM */
> > <0x01 0x00000000 0x01 0x00000000 0x00 0x00310000>, /* A53 PERIPHBASE */
> > <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, /* FSS0 DAT3 */
> > + <0x00 0x3b000000 0x00 0x3b000000 0x00 0x00000400>, /* GPMC0 CFG */
> > + <0x00 0x50000000 0x00 0x50000000 0x00 0x08000000>, /* GPMC0 DATA */
> > /* MCU Domain Range */
> > <0x00 0x04000000 0x00 0x04000000 0x00 0x01ff1400>,
>
> --
> cheers,
> -roger
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-04 12:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 11:12 [PATCH v2 0/3] Add support for GPMC NAND Nitin Yadav
2023-10-04 11:12 ` [PATCH v2 1/3] arm64: dts: ti: Add GPMC support for AM62x LP SK Nitin Yadav
2023-10-04 11:27 ` Roger Quadros
2023-10-04 12:07 ` Nishanth Menon [this message]
2023-10-04 12:12 ` Nishanth Menon
2023-10-04 11:12 ` [PATCH v2 2/3] arm64: dts: ti: Add overlay for NAND daughter card Nitin Yadav
2023-10-04 11:33 ` Roger Quadros
2023-10-04 11:12 ` [PATCH v2 3/3] arm64: defconfig: Enable GPMC NAND support Nitin Yadav
2023-10-04 11:26 ` Roger Quadros
2023-10-04 12:06 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004120749.p253uqn43s47qjud@blend \
--to=nm@ti.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n-yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox