From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 121D9E936E2 for ; Wed, 4 Oct 2023 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V0wGbx9mEBtM18ovthnVjtuDy03i55ZAv0WF548UhTo=; b=L2OI1x9lF/VJTJ EItrdOg974eBv6WPEMI0cILTPiT5CEnq7LCbJP5Rcxa59F11K4l9aKAsFD3uSQQ2xxrlYXKZCfNPi t1yq32eaqWnCBasZokViHeiquLfza3I19VZq8RACaMzAsKWwktAW93d1pObDB3XLu3VMP0CLc1YiN ZcY71ur/doJ1yxE/6YPSXDoikd9E0bNN0m7F/ey0bTGa9HKXp2K84LTQ4/u+FsCmobgVBCN3aOLAa dTiya4eYRry0YUzqlHk/x5gwXBoMjFb4gAFGiRmgqoCq/A9JWrwn/ZdtrKNkiw3LLbDgE+MsBghvz /qAcd2MzYynwtegDJcJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo8gG-000sfl-0U; Wed, 04 Oct 2023 20:41:16 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qo8gA-000sdW-1c for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 20:41:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D7985CE1EFE; Wed, 4 Oct 2023 20:41:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650C3C433C8; Wed, 4 Oct 2023 20:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696452068; bh=72lPpExPa7/l8tL0qUn7j7l+TWc7n+AL+YkQK0hH4Rs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=atmaCxJFjkuoGabbdB9Yr5oZJNjn/Bdzqi3HITjYF6aqnSMDpHMH5bfp99hp4hu9S ZLej3ZVqDIlgcOCVWEh/z1TfL0JlJy7ejY/tVkUEWh1lkzML859fY26D21NbzrJ6oS mZcJ+vs7HWLQWYMCkiilFAeuUE/i91yUMQRGVUSmATPRArfZ/68UMXOIcLCjXFgITR wVUTJ633op4v50sGt+9IYH/R3RFQhOsfrKs39O9GDD2IyBBuYeIH5PxlHeeAI3bdao DlShNOOgHT0wJGGHJbTENeMzo8Da3kPKTYi2A+7IvcTnZxvavLahGW7enZIs7mVro3 9tzhl8wqhc7fQ== Date: Wed, 4 Oct 2023 13:41:06 -0700 From: Jakub Kicinski To: Radhey Shyam Pandey Cc: , , , , , , , , , , , , , , "Sarath Babu Naidu Gaddam" Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support Message-ID: <20231004134106.7779c29c@kernel.org> In-Reply-To: <1695843151-1919509-3-git-send-email-radhey.shyam.pandey@amd.com> References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com> <1695843151-1919509-3-git-send-email-radhey.shyam.pandey@amd.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_134110_715120_43C5D031 X-CRM114-Status: UNSURE ( 6.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote: > */ > -static int axienet_open(struct net_device *ndev) > + nit: spurious new line > +static inline int axienet_init_legacy_dma(struct net_device *ndev) nit: no need for the inline, it has one caller and isn't on the fast path _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel