Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

From: Greg KH <gregkh@linuxfoundation.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: Nuno Das Neves <nunodasneves@linux.microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"patches@lists.linux.dev" <patches@lists.linux.dev>,
	"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
	KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"apais@linux.microsoft.com" <apais@linux.microsoft.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	"ssengar@linux.microsoft.com" <ssengar@linux.microsoft.com>,
	MUKESH RATHOR <mukeshrathor@microsoft.com>,
	"stanislav.kinsburskiy@gmail.com"
	<stanislav.kinsburskiy@gmail.com>,
	"jinankjain@linux.microsoft.com" <jinankjain@linux.microsoft.com>,
	vkuznets <vkuznets@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"will@kernel.org" <will@kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>
Subject: Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs
Date: Wed, 4 Oct 2023 19:50:31 +0200	[thread overview]
Message-ID: <2023100415-diving-clapper-a2a7@gregkh> (raw)
In-Reply-To: <SA1PR21MB1335F5145ACB0ED4F378105ABFCBA@SA1PR21MB1335.namprd21.prod.outlook.com>

On Wed, Oct 04, 2023 at 05:36:32PM +0000, Dexuan Cui wrote:
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Tuesday, October 3, 2023 11:10 PM
> > [...]
> > On Tue, Oct 03, 2023 at 04:37:01PM -0700, Nuno Das Neves wrote:
> > > On 9/30/2023 11:19 PM, Greg KH wrote:
> > > > On Sat, Sep 30, 2023 at 10:01:58PM +0000, Wei Liu wrote:
> > > > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote:
> > > > > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote:
> > > > > > > +/* Define connection identifier type. */
> > > > > > > +union hv_connection_id {
> > > > > > > +   __u32 asu32;
> > > > > > > +   struct {
> > > > > > > +           __u32 id:24;
> > > > > > > +           __u32 reserved:8;
> > > > > > > +   } __packed u;
> 
> IMO the "__packed" is unnecessary.
> 
> > > > > > bitfields will not work properly in uapi .h files, please never do that.
> > > > >
> > > > > Can you clarify a bit more why it wouldn't work? Endianess? Alignment?
> > > >
> > > > Yes to both.
> > > >
> > > > Did you all read the documentation for how to write a kernel api?  If
> > > > not, please do so.  I think it mentions bitfields, but it not, it really
> > > > should as of course, this will not work properly with different endian
> > > > systems or many compilers.
> > >
> > > Yes, in
> > https://docs.k/
> > ernel.org%2Fdriver-
> > api%2Fioctl.html&data=05%7C01%7Cdecui%40microsoft.com%7Ce404769e0f
> > 85493f0aa108dbc4a08a27%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C
> > 0%7C638319966071263290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%
> > 7C%7C&sdata=RiLNA5DRviWBQK6XXhxC4m77raSDBb%2F0BB6BDpFPUJY%3D
> > &reserved=0 it says that it is
> > > "better to avoid" bitfields.
> > >
> > > Unfortunately bitfields are used in the definition of the hypervisor
> > > ABI. We import these definitions directly from the hypervisor code.
> >
> > So why do you feel you have to use this specific format for your
> > user/kernel api?  That is not what is going to the hypervisor.
> 
> If it's hard to avoid bitfield here, maybe we can refer to the definition of
> struct iphdr in include/uapi/linux/ip.h

It is not hard to avoid using bitfields, just use the proper definitions
to make this portable for all compilers.  And ick, ip.h is not a good
thing to follow :)

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel