From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 974CFE7C4D0 for ; Wed, 4 Oct 2023 15:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0JV0ivkY+hZROKzN0nFOvzAPIthPh9QWe+ateXP+9Iw=; b=IpH79RKQZYEoxd aKJV36DM1fkSvgvRbBBZg2/EintNnY87fAnd5mMFvZ/0svje4TKL1/EGPdJkgsKSWsdJtaoS2IEc2 knkTQXNaWclS6ua35AUqPl4mL7fgtPz1MGTrOrcDksM2km+TlwTCC9jPTUk2bSE1DGtHGNPKQzIoV Ol8NVZ7IbwMSNPMvV+YHqiQR6LEI9FVn6IaWYUnCc0lFSNNy4aeVdxDWfDY23LGlSSZNBmH83E1HA rP3LvDluxoVYrW1UjPXhNEyIYo3aUZ2NiojQyatF4L8cjcd7fcMwF1tGNa/Y53EdYz4jKZ0280zBH Ac8p7vW1J0AzBIFu8v5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo3re-000MYW-2E; Wed, 04 Oct 2023 15:32:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo3rb-000MXV-2h for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 15:32:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFE9EC15; Wed, 4 Oct 2023 08:33:16 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 422893F762; Wed, 4 Oct 2023 08:32:37 -0700 (PDT) Date: Wed, 4 Oct 2023 16:32:34 +0100 From: Sudeep Holla To: Olivier Deprez Cc: Jens Wiklander , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Marc Bonnici , Sudeep Holla , Coboy Chen , Lorenzo Pieralisi Subject: Re: [PATCH v3 03/17] firmware: arm_ffa: Implement the notification bind and unbind interface Message-ID: <20231004153234.ktk6egntk7drao47@bogus> References: <20230929-ffa_v1-1_notif-v3-0-c8e4f15190c8@arm.com> <20230929-ffa_v1-1_notif-v3-3-c8e4f15190c8@arm.com> <20231004091154.GB1091193@rayden> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_083239_919938_9CA31D9C X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 04, 2023 at 10:50:26AM +0100, Olivier Deprez wrote: > Hi Jens, > > > dst_id and drv_info->vm_id should be swapped. > > I'm curious about this because swapping like this actually makes hafnium > fail. Need to check from the spec. I did check after I had swapped this in v2(because I was convinced Jens) was correct and you reported the failure. Reading the spec again the other day, I got corrected myself and agreed with Olivier and my original implementation(v1) which matches this patch(v3). -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel