From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6824E7B5F9 for ; Wed, 4 Oct 2023 12:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QgMiEmUAW7S52jIVEXo3dLN4EUiVmUDYcek1h96r18g=; b=udQTaizLPKsC+t 748gdsci2XQEPtx64j1GsX8T1CWudu1e16eLfRlRCUBD1NO+KczORwexXYFmmheLyB/Qb+SbFrvUl s/upxttLz+h6LGuWjPGehQh6ZIc4yiOwMUEJuhbWs9A6ffyF4h4x5dB0dchK3zTI4dtmDg8Gt8MTz 86CX8IRTZVwf/S9OxOx+AgUFs7WnVD2l+Fl+Pz5piR+WPtyOwW/mYiZbKshnlQ2lY7illijT9S4Vb Vq4mWmXD4l5ZyNXWpRR+BLUbliPkRUsNIQFo0OtbXBnDWNpvBqk1lj3iW/2aqBjcWNeknfqX9kHwz Uo9YdCehhK4tqWK+7wKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo0lm-00HZyW-0H; Wed, 04 Oct 2023 12:14:26 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qo0lj-00HZy0-1Z for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 12:14:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 138C4B81D0D; Wed, 4 Oct 2023 12:14:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9A82C433C7; Wed, 4 Oct 2023 12:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696421661; bh=fff8v4/61tUh9ShqU1effVhQXWYy0R5I3axgVxyLMdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNeyRWRUwC5JCM5xWi8dJGga5y1/nbhWwSwWkY49upOOACupldRtZZyPqPQmHff2v eKcl2P6jcvWpkeSO6LcRo7NGwbz4iQOrKc5ArLWaJ+wYRyspXSAOb4xkRYx/WmoQuO /YjdMFWLzoV2hnJ7I/xD90peMPrIaZhj8tHZvu8Q= Date: Wed, 4 Oct 2023 14:14:18 +0200 From: Greg KH To: Jay Buddhabhatti Cc: michal.simek@amd.com, tanmay.shah@amd.com, nava.kishore.manne@amd.com, ben.levinsky@amd.com, robh@kernel.org, dhaval.r.shah@amd.com, marex@denx.de, izhar.ameer.shaikh@amd.com, arnd@arndb.de, ruanjinjie@huawei.com, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/6] firmware: xilinx: Update firmware call interface to support additional arg Message-ID: <2023100445-rising-brittle-fe69@gregkh> References: <20231004094116.27128-1-jay.buddhabhatti@amd.com> <20231004094116.27128-2-jay.buddhabhatti@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231004094116.27128-2-jay.buddhabhatti@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_051423_678349_BE4DE3E8 X-CRM114-Status: UNSURE ( 7.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 04, 2023 at 02:41:11AM -0700, Jay Buddhabhatti wrote: > int zynqmp_pm_invoke_fn(u32 pm_api_id, u32 arg0, u32 arg1, > - u32 arg2, u32 arg3, u32 *ret_payload) > + u32 arg2, u32 arg3, u32 arg4, > + u32 *ret_payload) You do have 100 columns to use now, why wrap? Same for other places you did this. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel