* [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
@ 2023-10-05 14:54 Benjamin Gaignard
2023-10-05 15:12 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Gaignard @ 2023-10-05 14:54 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, heiko
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
kernel, Benjamin Gaignard, Sebastian Reichel
Add node for AV1 video decoder.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 5544f66c6ff4..835e66d85d5f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -2304,6 +2304,20 @@ gpio4: gpio@fec50000 {
#interrupt-cells = <2>;
};
};
+
+ av1d: av1d@fdc70000 {
+ compatible = "rockchip,rk3588-av1-vpu";
+ reg = <0x0 0xfdc70000 0x0 0x800>;
+ interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH 0>;
+ interrupt-names = "vdpu";
+ clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
+ clock-names = "aclk", "hclk";
+ assigned-clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
+ assigned-clock-rates = <400000000>, <400000000>;
+ resets = <&cru SRST_A_AV1>, <&cru SRST_P_AV1>, <&cru SRST_A_AV1_BIU>, <&cru SRST_P_AV1_BIU>;
+ power-domains = <&power RK3588_PD_AV1>;
+ status = "okay";
+ };
};
#include "rk3588s-pinctrl.dtsi"
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
2023-10-05 14:54 [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node Benjamin Gaignard
@ 2023-10-05 15:12 ` Sebastian Reichel
2023-10-05 15:30 ` Heiko Stuebner
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2023-10-05 15:12 UTC (permalink / raw)
To: Benjamin Gaignard
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, heiko, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, kernel
[-- Attachment #1.1: Type: text/plain, Size: 1845 bytes --]
Hi,
On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote:
> Add node for AV1 video decoder.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
No need for my SoB. Instead have this one:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Also worth mentioning, that this Patch needs one small fix in the DT
binding (adding "resets") and one small fix in the driver for out of
the box AV1 support:
https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/
https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/
Greetings,
-- Sebastian
> ---
> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> index 5544f66c6ff4..835e66d85d5f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> @@ -2304,6 +2304,20 @@ gpio4: gpio@fec50000 {
> #interrupt-cells = <2>;
> };
> };
> +
> + av1d: av1d@fdc70000 {
> + compatible = "rockchip,rk3588-av1-vpu";
> + reg = <0x0 0xfdc70000 0x0 0x800>;
> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "vdpu";
> + clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
> + clock-names = "aclk", "hclk";
> + assigned-clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
> + assigned-clock-rates = <400000000>, <400000000>;
> + resets = <&cru SRST_A_AV1>, <&cru SRST_P_AV1>, <&cru SRST_A_AV1_BIU>, <&cru SRST_P_AV1_BIU>;
> + power-domains = <&power RK3588_PD_AV1>;
> + status = "okay";
> + };
> };
>
> #include "rk3588s-pinctrl.dtsi"
> --
> 2.39.2
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
2023-10-05 15:12 ` Sebastian Reichel
@ 2023-10-05 15:30 ` Heiko Stuebner
2023-10-05 15:39 ` Benjamin Gaignard
0 siblings, 1 reply; 5+ messages in thread
From: Heiko Stuebner @ 2023-10-05 15:30 UTC (permalink / raw)
To: Benjamin Gaignard, Sebastian Reichel
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, kernel
Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel:
> Hi,
>
> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote:
> > Add node for AV1 video decoder.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> No need for my SoB. Instead have this one:
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Also worth mentioning, that this Patch needs one small fix in the DT
> binding (adding "resets") and one small fix in the driver for out of
> the box AV1 support:
>
> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/
> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/
additionally the node name should be generic.
The phandle can of course be av1d but the node
name itself needs a change.
Heiko
> > ---
> > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > index 5544f66c6ff4..835e66d85d5f 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > @@ -2304,6 +2304,20 @@ gpio4: gpio@fec50000 {
> > #interrupt-cells = <2>;
> > };
> > };
> > +
> > + av1d: av1d@fdc70000 {
> > + compatible = "rockchip,rk3588-av1-vpu";
> > + reg = <0x0 0xfdc70000 0x0 0x800>;
> > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH 0>;
> > + interrupt-names = "vdpu";
> > + clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
> > + clock-names = "aclk", "hclk";
> > + assigned-clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
> > + assigned-clock-rates = <400000000>, <400000000>;
> > + resets = <&cru SRST_A_AV1>, <&cru SRST_P_AV1>, <&cru SRST_A_AV1_BIU>, <&cru SRST_P_AV1_BIU>;
> > + power-domains = <&power RK3588_PD_AV1>;
> > + status = "okay";
> > + };
> > };
> >
> > #include "rk3588s-pinctrl.dtsi"
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
2023-10-05 15:30 ` Heiko Stuebner
@ 2023-10-05 15:39 ` Benjamin Gaignard
2023-10-05 15:43 ` Heiko Stuebner
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Gaignard @ 2023-10-05 15:39 UTC (permalink / raw)
To: Heiko Stuebner, Sebastian Reichel
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, kernel
Le 05/10/2023 à 17:30, Heiko Stuebner a écrit :
> Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel:
>> Hi,
>>
>> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote:
>>> Add node for AV1 video decoder.
>>>
>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>> No need for my SoB. Instead have this one:
>>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>>
>> Also worth mentioning, that this Patch needs one small fix in the DT
>> binding (adding "resets") and one small fix in the driver for out of
>> the box AV1 support:
>>
>> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/
>> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/
> additionally the node name should be generic.
> The phandle can of course be av1d but the node
> name itself needs a change.
Does "video-codec-av1@fdc70000" sound good for you ?
>
> Heiko
>
>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>>> index 5544f66c6ff4..835e66d85d5f 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>>> @@ -2304,6 +2304,20 @@ gpio4: gpio@fec50000 {
>>> #interrupt-cells = <2>;
>>> };
>>> };
>>> +
>>> + av1d: av1d@fdc70000 {
>>> + compatible = "rockchip,rk3588-av1-vpu";
>>> + reg = <0x0 0xfdc70000 0x0 0x800>;
>>> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH 0>;
>>> + interrupt-names = "vdpu";
>>> + clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
>>> + clock-names = "aclk", "hclk";
>>> + assigned-clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
>>> + assigned-clock-rates = <400000000>, <400000000>;
>>> + resets = <&cru SRST_A_AV1>, <&cru SRST_P_AV1>, <&cru SRST_A_AV1_BIU>, <&cru SRST_P_AV1_BIU>;
>>> + power-domains = <&power RK3588_PD_AV1>;
>>> + status = "okay";
>>> + };
>>> };
>>>
>>> #include "rk3588s-pinctrl.dtsi"
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
2023-10-05 15:39 ` Benjamin Gaignard
@ 2023-10-05 15:43 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2023-10-05 15:43 UTC (permalink / raw)
To: Sebastian Reichel, Benjamin Gaignard
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, kernel
Am Donnerstag, 5. Oktober 2023, 17:39:18 CEST schrieb Benjamin Gaignard:
>
> Le 05/10/2023 à 17:30, Heiko Stuebner a écrit :
> > Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel:
> >> Hi,
> >>
> >> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote:
> >>> Add node for AV1 video decoder.
> >>>
> >>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >> No need for my SoB. Instead have this one:
> >>
> >> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >>
> >> Also worth mentioning, that this Patch needs one small fix in the DT
> >> binding (adding "resets") and one small fix in the driver for out of
> >> the box AV1 support:
> >>
> >> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/
> >> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/
> > additionally the node name should be generic.
> > The phandle can of course be av1d but the node
> > name itself needs a change.
>
> Does "video-codec-av1@fdc70000" sound good for you ?
Nope ... please go with
video-codec@fdc...
I.e. see the other Rockchip soc dtsi for reference.
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-05 15:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05 14:54 [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node Benjamin Gaignard
2023-10-05 15:12 ` Sebastian Reichel
2023-10-05 15:30 ` Heiko Stuebner
2023-10-05 15:39 ` Benjamin Gaignard
2023-10-05 15:43 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).