From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5431E8FDC8 for ; Thu, 5 Oct 2023 10:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TiwZneLvofzKX12fG2WAXQID0+aWia4KYJcHZ8Ft41g=; b=2XATcOIrAuzgB4 GtWp6MVJzMomrNJDugtYAwOkD3DgHrdk2I1BNiGiLxC3cgrq61loY7FEVnQ+Ynl7XMdPr6422Ga8G GTgSteNWMDcheue8Lyx2BzwsQefX14foy9c/HqjqbwFIjFseNvxbG7FgrL2+offvMZcpFf/Z3E/uJ Qxb0ubtHCQ3i0KJBmjj8YpHlg4UxBXa561Y+udWgr7tqlkkimzIhhPv/LE+LnfpKP7R23R7hB1h2+ c8ThE5a6nA1FvCNzlFoS0VMFGkMq9fInGk3NbEDlmLmh5I0JiiUiBIlOHHvBOxl7EIqoZUHbYwfEO 964y1AsJKaovSSPdaM2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoLZg-001tFB-1Z; Thu, 05 Oct 2023 10:27:20 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoLZc-001tEU-0F for linux-arm-kernel@lists.infradead.org; Thu, 05 Oct 2023 10:27:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 5E4B3B823E1; Thu, 5 Oct 2023 10:27:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FFFCC2BCFE; Thu, 5 Oct 2023 10:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696501633; bh=4fxCXTLyJSEnYgLs6b+JCuhTnShTf/CIKp0OZexQrj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HHqX91JuhSpBSMK2o5ESJ0CBb18LLzCffYRKge9Capj2sJtPUdKCWOaxUiEofWFwy YXYbGFcxtC72+SdtbwVaoy04zAaGLRi5fcM2EwOsKJDm8EESrPXXCLBrKNo9yC3Sf6 J/H2XeTyxw7J+SIcHLdbKmLBsKxTOxNeiNxlLrWI= Date: Thu, 5 Oct 2023 12:27:10 +0200 From: Greg KH To: Nuno Das Neves Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs Message-ID: <2023100517-rogue-gopher-e70f@gregkh> References: <1696010501-24584-1-git-send-email-nunodasneves@linux.microsoft.com> <1696010501-24584-14-git-send-email-nunodasneves@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1696010501-24584-14-git-send-email-nunodasneves@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_032716_325396_3B1E0073 X-CRM114-Status: UNSURE ( 8.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > +/* Define connection identifier type. */ > +union hv_connection_id { > + __u32 asu32; > + struct { > + __u32 id:24; > + __u32 reserved:8; Meta-commment, I don't see anywhere you are properly checking that all of the "reserved" areas of these structures are actually set to 0 when they are sent to you. If you don't do that, then they are not really reserved at all and can never be used in the future, so properly check them please. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel