From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F833E7C4F6 for ; Thu, 5 Oct 2023 08:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=89uEXNsGs9KOTQiLKc9ZNzjwSXjSn0oPHN8h1f6ryyU=; b=g1ZiLGypucA5xo 3+7HTmxPNvDTwGfMJ0CG1kmIbVWgvYRFUHZ/C7zp/8g3RhFcCd/6FR0MBPvWpRezsQtTBlD1Q2WVS Yp+BYC2/nblEGFvtvGvHiqZZkQlwbB/aCesIKsR2i5SqHzOYeS+h/jxl42WwsQJWYBCdm/8IUQfoQ zD/GAYq/JXeXAW0xI+uRvV+3iKiImDPrytU2ZI6K4/isVJy8cSsSoDbrZlDwW6hF3Mp4PXCTPCtT5 Nk5I/VHbIELpCUrUju3Kqm76H1xUhyLS6LGXIwnvXEOUgw/kp5IgfblR4cyCvciVBDJxpGmskXWw4 t+cswdBRXxt0MctJ8KpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoJLm-001e50-0O; Thu, 05 Oct 2023 08:04:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoJLg-001e43-2y; Thu, 05 Oct 2023 08:04:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 266936187A; Thu, 5 Oct 2023 08:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D891C116A8; Thu, 5 Oct 2023 08:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696493083; bh=n0iBSjPCJkTWykMjXg2IpQ/zpWh4QfV3NqOyRltJBhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZCfl+kBAeFYIZUswnR8uZMzh5QaIJPbx13BP7AgAhJj9nSlwojL7hm97zgFR+Yxm5 7/oFKTMm3x9km0Lwzc0wP8DTaW0x1ExhMFUQSaP0H9MdSTmVzeaD/awJ0BZawcZOeG hjVoG3S3lyssDem651xtmzWvVyey+eIoIQcBc7p4= Date: Thu, 5 Oct 2023 10:04:41 +0200 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH v12 6/6] staging: bcm2835-audio: Register bcm2835-audio with vchiq_bus_type Message-ID: <2023100523-comprised-eggnog-bd20@gregkh> References: <20230923143200.268063-1-umang.jain@ideasonboard.com> <20230923143200.268063-7-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230923143200.268063-7-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_010445_005714_6A492C9C X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 23, 2023 at 08:02:00PM +0530, Umang Jain wrote: > Similar to how bcm2385-camera device is registered, register the > bcm2835-audio with vchiq_bus_type as well. > > Since we moved away bcm2835-audio from platform driver/device, > we have to set the DMA mask explicitly. Set the DMA mask at probe > time. > > Meanwhile at it, change the name and module alias from "bcm2835_audio" > to "bcm2835-audio" to be consistent with bcm2835-camera device. This > does not brings any functional change as '-' and '_' are > interchangeable as per modprobe man pages. Again, why is the module alias still needed? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel