From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D397E7C4F6 for ; Thu, 5 Oct 2023 08:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z6VAgDtPrPZc33qRoZhOpCBuB8ofcw0mNf6gyB/pb/U=; b=XrQsf4Offtu81E 9Ta/i4oTpcBka6oT/DC2Qby9CHOpjp5NBJqKiZ0kc6sOa+pAi2KjKENH2pTueWzFrOcu1LNw9Ag40 BGadNmG2K60OC+c71OL8Bdan65syAMwnJ5uR3QzWZChC537lBMMHz97sXqy2R2PWk0JQz0EnqgbBx p6mgiWEmgv7xMVRtv8RVeZpEwUdW5PRfCqkqcqEyooGwPaaZyBK/h+yROlalJVJ2BdJUESae/70Oj dMDkTmzNbfqZbeghFbggafi1SEBKnrBLBeszPLB6vzEG8JmrSZOi1ELaW7VkojOZRC7KcAot9vMrB cY9pyiEv2GTVZ0zMBBlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoJKP-001dqt-28; Thu, 05 Oct 2023 08:03:25 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoJKL-001dpm-2K; Thu, 05 Oct 2023 08:03:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 19BD3B82311; Thu, 5 Oct 2023 08:03:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE1E1C4167D; Thu, 5 Oct 2023 08:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696492995; bh=KPcsr8XqpbliBlKBPCcy5Hq2QiFVd1C2DY5JYyEzUlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xqMrGdRZjefjkoDX+uLyUyc4vTxSFrrACPkJoZRaixGShQastWySJ0hAkcvZL6hIw +CqrL1aIdDTQHDqaIa57Xpys7Mg2izH/rD1v4A/AbVoDb2byyxBJyTmtFSOx7pPYjt KpH7ADhN9TDhDwDKQLQwwpFetiaXsBKph2/HaBCw= Date: Thu, 5 Oct 2023 10:03:12 +0200 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH v12 3/6] staging: vc04_services: vchiq_arm: Add new bus type and device type Message-ID: <2023100525-deflator-procedure-8d96@gregkh> References: <20230923143200.268063-1-umang.jain@ideasonboard.com> <20230923143200.268063-4-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230923143200.268063-4-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_010322_066996_CA7C479E X-CRM114-Status: GOOD ( 26.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 23, 2023 at 08:01:57PM +0530, Umang Jain wrote: > The devices that the vchiq interface registers (bcm2835-audio, > bcm2835-camera) are implemented and exposed by the VC04 firmware. > The device tree describes the VC04 itself with the resources required > to communicate with it through a mailbox interface. However, the > vchiq interface registers these devices as platform devices. This > also means the specific drivers for these devices are getting > registered as platform drivers. This is not correct and a blatant > abuse of platform device/driver. > > Add a new bus type, vchiq_bus_type and device type (struct vchiq_device) > which will be used to migrate child devices that the vchiq interfaces > creates/registers from the platform device/driver. > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/Makefile | 1 + > .../interface/vchiq_arm/vchiq_bus.c | 100 ++++++++++++++++++ > .../interface/vchiq_arm/vchiq_bus.h | 54 ++++++++++ > 3 files changed, 155 insertions(+) > create mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c > create mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h > > diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile > index 44794bdf6173..e8b897a7b9a6 100644 > --- a/drivers/staging/vc04_services/Makefile > +++ b/drivers/staging/vc04_services/Makefile > @@ -4,6 +4,7 @@ obj-$(CONFIG_BCM2835_VCHIQ) += vchiq.o > vchiq-objs := \ > interface/vchiq_arm/vchiq_core.o \ > interface/vchiq_arm/vchiq_arm.o \ > + interface/vchiq_arm/vchiq_bus.o \ > interface/vchiq_arm/vchiq_debugfs.o \ > interface/vchiq_arm/vchiq_connected.o \ > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c > new file mode 100644 > index 000000000000..4ac3491efe45 > --- /dev/null > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c > @@ -0,0 +1,100 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * vchiq_device.c - VCHIQ generic device and bus-type > + * > + * Copyright (c) 2023 Ideas On Board Oy > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include "vchiq_bus.h" > + > +static int vchiq_bus_type_match(struct device *dev, struct device_driver *drv) > +{ > + if (dev->bus == &vchiq_bus_type && > + strcmp(dev_name(dev), drv->name) == 0) > + return true; > + > + return false; > +} > + > +static int vchiq_bus_uevent(const struct device *dev, struct kobj_uevent_env *env) > +{ > + const struct vchiq_device *device = container_of_const(dev, struct vchiq_device, dev); > + > + return add_uevent_var(env, "MODALIAS=%s", dev_name(&device->dev)); > +} > + > +static int vchiq_bus_probe(struct device *dev) > +{ > + struct vchiq_device *device = to_vchiq_device(dev); > + struct vchiq_driver *driver = to_vchiq_driver(dev->driver); > + > + return driver->probe(device); > +} > + > +struct bus_type vchiq_bus_type = { > + .name = "vchiq-bus", > + .match = vchiq_bus_type_match, > + .uevent = vchiq_bus_uevent, > + .probe = vchiq_bus_probe, > +}; > + > +static void vchiq_device_release(struct device *dev) > +{ > + struct vchiq_device *device = to_vchiq_device(dev); > + > + kfree(device); > +} > + > +struct vchiq_device * > +vchiq_device_register(struct device *parent, const char *name) > +{ > + struct vchiq_device *device; > + int ret; > + > + device = kzalloc(sizeof(*device), GFP_KERNEL); > + if (!device) > + return NULL; > + > + device->dev.init_name = name; > + device->dev.parent = parent; > + device->dev.bus = &vchiq_bus_type; > + device->dev.dma_mask = &device->dev.coherent_dma_mask; > + device->dev.release = vchiq_device_release; > + > + of_dma_configure(&device->dev, parent->of_node, true); > + > + ret = device_register(&device->dev); > + if (ret) { > + dev_err(parent, "Cannot register %s: %d\n", name, ret); > + put_device(&device->dev); > + kfree(device); As per the documentation for the device_register() call, this kfree() will crash. The call to put_device() is all you need here to free the memory. I'll take this series as it's been reviewed and tested, but can you send a follow-on patch for this? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel