From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADF95E92FFA for ; Fri, 6 Oct 2023 09:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qhMrmqtus4bgZQvoecmCZbgmDsrI2fmeDc4JJQ8MFvE=; b=TQmT5A92smnX7UhQ+ce3KCeZhn pSTV9kkK3NvinAchnqwe/heKRyd7byvywgC2kNUPLBBzTPYY3Xp+A2e4/WrUoScQIG1PIk4BrkjA2 s/n1WrFbSynwgJzImXKDK1aTkfQWQdZvtWb6NmSnoK0anz/Rdxv/aghfM12ys5B6EcpnGZPOnsudp SkXHJqbNEdIrUjP7TyXs3CXzkQfNmSC0K4l3RSO1Y+F7v29QT6RQ7x/ZcdAqwXp+sGnuFoCiz6EzA 9fRtMwYooT6Ayy8js5ZMI0ga0837/aCaCwq2HPMdF/xib5VT7ySfKyQ5YlK7wo+l/7WVOE41gfXaY OVqr4t5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoh9v-005OTv-1s; Fri, 06 Oct 2023 09:30:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoh9s-005OSe-1h for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 09:30:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 983FB61CD6; Fri, 6 Oct 2023 09:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C5D0C433C7; Fri, 6 Oct 2023 09:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696584606; bh=X+gyCNuttx65afYQmM1XbC4BVY4NKTMe7P7eG20cYvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oV7nJE7trH7bHWGst1p5CracmcgyV+yxJgvIYJjBvDO+4wbhBd7cmRmCODWBswK5X hZMVnT4NSmZcMTMfN1i9In0nTOV8vBcqJdmE2edGy5146U4TdBL1EFFqzAPZWB/Ahr r2xFiy8FBjjokRqDZ3PQQqXmLFIv6dePXvvAZ9hZlfOy7AXtAw5+PsqcZtPOAFFePk nn3XUUtKP6sl0Stg6kzdKCk6eXcHDBejQdpvoo0MERUO3ScnWJKgzxum7iG4mxNmF+ CfYWAcfvLgppuNGExUmaTGQGAmoKMmP0pK6LR87zJANzr58PbEnPVkwVgcH3yiIJfv N9FrwDLLqUk/w== Date: Fri, 6 Oct 2023 10:30:00 +0100 From: Conor Dooley To: Christophe ROULLIER Cc: Rob Herring , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/12] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Message-ID: <20231006-storable-smugness-6a6820ebb6cf@spud> References: <20230928151512.322016-1-christophe.roullier@foss.st.com> <20230928151512.322016-3-christophe.roullier@foss.st.com> <20230928-ruse-parsnip-ce691bd4d0c9@spud> <85e3b93c-36b2-cb4c-9438-ad05d24b3332@foss.st.com> MIME-Version: 1.0 In-Reply-To: <85e3b93c-36b2-cb4c-9438-ad05d24b3332@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_023008_653158_57215BDF X-CRM114-Status: GOOD ( 33.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2695049142535908915==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2695049142535908915== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XWEolTRpRQdNMg4C" Content-Disposition: inline --XWEolTRpRQdNMg4C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 05, 2023 at 11:03:43AM +0200, Christophe ROULLIER wrote: >=20 > On 9/28/23 19:17, Conor Dooley wrote: > > On Thu, Sep 28, 2023 at 05:15:02PM +0200, Christophe Roullier wrote: > > > Add property st,ext-phyclk to manage cases when PHY have no cristal/q= uartz > > > This property can be used with RMII phy without cristal 50Mhz and whe= n we > > > want to select RCC clock instead of ETH_REF_CLK > > > Can be used also with RGMII phy with no cristal and we select RCC clo= ck > > > instead of ETH_CLK125 > > > This new property replace st,eth-clk-sel and st,eth-ref-clk-sel > > I don't really see a response to Rob's comment on v2, either here or in > > a reply to his email on v2: > > | Certainly 1 property is better than 2 for me, but carrying 3 is not > > | great. I don't understand why the we need a new property. What can't = be > > | supported with the existing properties? > >=20 > > A sentence saying explaining exactly what the old properties do not > > support that this one does, would be very helpful. > I understand your remarks, the goal of the new property is to be more sim= ple > for customers/users >=20 > with old properties we have lots of support to explain which one to use in > which cases, now only one property to use (regardless of mode) I'm inclined to say "that's tough" & that the existing property descriptions should be improved rather than adding yet a third one. Maybe you're lucky and Rob disagrees with me :) Thanks, Conor. > > > Signed-off-by: Christophe Roullier > > > --- > > > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b= /Documentation/devicetree/bindings/net/stm32-dwmac.yaml > > > index ca976281bfc22..67840cab02d2d 100644 > > > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > > > @@ -78,12 +78,21 @@ properties: > > > encompases the glue register, the offset of the control regis= ter and > > > the mask to set bitfield in control register > > > + st,ext-phyclk: > > > + description: > > > + set this property in RMII mode when you have PHY without cryst= al 50MHz and want to > > > + select RCC clock instead of ETH_REF_CLK. or in RGMII mode when= you want to select > > > + RCC clock instead of ETH_CLK125. > > > + type: boolean > > > + > > > st,eth-clk-sel: > > > + deprecated: true > > > description: > > > set this property in RGMII PHY when you want to select RCC cl= ock instead of ETH_CLK125. > > > type: boolean > > > st,eth-ref-clk-sel: > > > + deprecated: true > > > description: > > > set this property in RMII mode when you have PHY without crys= tal 50MHz and want to > > > select RCC clock instead of ETH_REF_CLK. > > > --=20 > > > 2.25.1 > > >=20 --XWEolTRpRQdNMg4C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZR/TlwAKCRB4tDGHoIJi 0htAAPoDIpGKoxqgwmpbLaqFYFbJoORCve21nUaBMeoV7oXrnwEA7WAWoOsddrra Y6AaAwcSOdndS0cRdxGuTlwC24VpXQs= =i9+i -----END PGP SIGNATURE----- --XWEolTRpRQdNMg4C-- --===============2695049142535908915== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2695049142535908915==--