From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D770AE81DE8 for ; Fri, 6 Oct 2023 12:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iRW7fDv1gv7KDrvK7P/16onLUZTAowCVF0HRmx4onCc=; b=lIpLa96aFKzxhd m1e1ibQxmp70HHfaTw7R43NwgFACl4nHUjOyAJbnwxOWqdAl365GP6tqe2DQMm8vlA+/V9Gb70tS2 IkizJb4rzfxGj/8U+T4CMqrtYQVzDSmG/0jLx3m8PxoCWolINlD21Rk/vyPtAEzzvCaERpn624sZx 5yYEpORfZTZngx3hUop0sGJHR4UzM1ewsGyonICHcM6hvxGfW9W7Ts3YmYhA4nwSfIif4UnBTdaDt jbTrKvNMz2Yix+hAIvwY4RQWym13moyw35/35A9N5yuH9P7AyHHaaAm0DfgT0CWEJyyiQ+nGjrV9R evLNJzAhVQP6iaKuojmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qojWL-005jnD-2p; Fri, 06 Oct 2023 12:01:29 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qojWJ-005jmr-1v for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 12:01:29 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 396C1MdI105328; Fri, 6 Oct 2023 07:01:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696593682; bh=lpD2epWNlmiS8XYq+aJ7VOLQ2+oJck78368nfWClxjI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=pwuld3sXHg6btu5ribAn9L4pEvYqbAA6wkP2e1Zimg9ZRuWjlCbNLGeII1WhmAnAd 42/SI6FvGoKbpvZMJja090NvkC/jxi/f8LKJQ9x0HFvTIjvZafStlhCiHNgHKUtdef tFACG0/6JM1/wtHdzI+/lTdFgf6HrIEA7l0kgdjc= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 396C1MPV125837 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Oct 2023 07:01:22 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 6 Oct 2023 07:01:22 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 6 Oct 2023 07:01:22 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 396C1MHN032309; Fri, 6 Oct 2023 07:01:22 -0500 Date: Fri, 6 Oct 2023 07:01:22 -0500 From: Nishanth Menon To: "J, KEERTHY" CC: , , , , , , , , Subject: Re: [PATCH v7 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the mcu domain watchdog instances Message-ID: <20231006120122.qkohphk6uq6kmxgm@pueblo> References: <20231006042901.6474-1-j-keerthy@ti.com> <20231006042901.6474-6-j-keerthy@ti.com> <20231006113410.tibvxxkeuujqnbv4@evolution> <9e3489f0-98f4-48ac-89a8-ea4ad3ee115c@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9e3489f0-98f4-48ac-89a8-ea4ad3ee115c@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_050127_718304_BD139C01 X-CRM114-Status: GOOD ( 29.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:22-20231006, J, KEERTHY wrote: > > > On 10/6/2023 5:04 PM, Nishanth Menon wrote: > > On 09:58-20231006, Keerthy wrote: > > > There are totally 2 instances of watchdog module in MCU domain. > > > These instances are coupled with the MCU domain R5F instances. > > > > > Disabling them as they are not used by Linux. > > Device tree is hardware description - not tied to how Linux uses it. > > > > Reason these wdts are disabled by default is because they are tightly > > coupled with R5Fs. > > > > > > > > Signed-off-by: Keerthy > > > --- > > > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 24 +++++++++++++++++++ > > > 1 file changed, 24 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > index a7b5c4cb7d3e..809a0b1cf038 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > @@ -714,4 +714,28 @@ > > > ti,esm-pins = <63>; > > > bootph-pre-ram; > > > }; > > > + > > Nishanth, > > Below i have addressed the coupling with R5Fs & MCU domains watcdogs. > > > > + /* > > > + * The 2 RTI instances are couple with MCU R5Fs so keeping them > > > + * disabled as these will be used by their respective firmware This description is best in the commit message > > > + */ > > > + mcu_watchdog0: watchdog@40600000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40600000 0x00 0x100>; > > > + clocks = <&k3_clks 367 1>; > > > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 367 0>; > > > + assigned-clock-parents = <&k3_clks 367 4>; > > > + status = "disabled"; > > > + }; > > > + > > > + mcu_watchdog1: watchdog@40610000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40610000 0x00 0x100>; > > > + clocks = <&k3_clks 368 1>; > > > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 368 0>; > > > + assigned-clock-parents = <&k3_clks 368 4>; > > > > Please DONOT ignore the review comments - I did ask the documentation in > > dts as well. reason being that this is what people will see rather than > > dig up the commit log. it should be intutive when reading the dts why > > nodes are disabled by default Vs the standard of leaving it enabled by > > default. Given esp that these peripherals do not have anything to do > > with board semantics (pinmux or something similar) to be complete. > > As mentioned above. I added single comment for addressing both the > watchdogs. I missed it completely. Now that I think of it, I seem to have missed having seen it in previous rev reviews as well, and there is a reason for it: See [1] clarifying comment - nodes reserved for firmware usage have convention of "reserved" as status and documentation immediately above the status to help clarify the reason in-context. That is more readable than having to scroll up to find the rationale. [1] https://lore.kernel.org/all/20231006114422.avymeap7h5ocs6zq@dreadlock/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel