From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F5CE94125 for ; Fri, 6 Oct 2023 21:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gPEmA7MDU4jyKnujAh8zjwzODvvudDGMSYQSo2DaiSY=; b=rxMBghJbcofN4V mbOUk0qVzN4ZsZKSY9i4GbakPhlKZ4MgbMHcIBpmZpZsKK/6w9Dy5DpJ5/6Uv0gYXmb02sOx9KtfJ ZvWIc6cuFtJYBXILJVJGce8oPQSUPGHUX6f+hcgL76Q/pbuXFk2tz1bAiehWn59cNCmYob6IkVJ+G uv29HPNH3fnouUH48mtEhQE2FPjV4yg+o4VyojKU+oSdlGFo1uEDkZcaxQLnRiCv+Mvhg/tuNnd7Z CnRFqEX7RPM+sc+Vv3oQT/rheIy3Wxq1Pr1e+NPOZONTCi8RLcVZzxg7OtHKTFwX3aa8ndGwf2Rlb KFKsk0B6RFztjahpvufQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qosR7-006W2D-2l; Fri, 06 Oct 2023 21:32:41 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qosR4-006Vzn-2O for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 21:32:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8F1FFCE28C1; Fri, 6 Oct 2023 21:32:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 449F2C433C7; Fri, 6 Oct 2023 21:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696627951; bh=sTC4CetYxtFnNBT5I33REzikDFDQsnbC2qzIKmyK4hU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bVi51T6WtnlsXeqgwnvqUdsxuGfdDCT+nMKIznhFwYLe99uSFZBmXJzRxHisAIeSn GPGf08DxN3ysRTlU+hJB8Qi/KwXXCMnjs2Gl5X7FY1/Iwnh9EhueFAm07PkJ5qzp3n gGLNtsRiovBFsPvSM30duKyt1AFGpLCVWwFYFCzPL3bzrQxqG7VMHqW2Lt9bW4bOz6 9ZDvIPhVMeB1MSYDGWCEl7Cwd1zNDgpMSDKwBNJkDpTAXzUCvhwkv47yp/3/lSK19F 3JJ5C/ZbASMIFErooWKUcbu+UzuiZRLJIL9SirtsjG/12h7SgFC18cTvXAIQTfQQFD W9Iehn5RdAoGQ== Date: Fri, 6 Oct 2023 14:32:30 -0700 From: Jakub Kicinski To: "Pandey, Radhey Shyam" Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "Simek, Michal" , "linux@armlinux.org.uk" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "git (AMD-Xilinx)" Subject: Re: [PATCH net-next v7 3/3] net: axienet: Introduce dmaengine support Message-ID: <20231006143230.4230fdc2@kernel.org> In-Reply-To: References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com> <1695843151-1919509-4-git-send-email-radhey.shyam.pandey@amd.com> <20231004135317.2b460acf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_143238_955961_3556DB86 X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 6 Oct 2023 19:04:29 +0000 Pandey, Radhey Shyam wrote: > > > + netif_stop_queue(ndev); > > > + if (net_ratelimit()) > > > + netdev_warn(ndev, "TX ring unexpectedly full\n"); > > > > I don't see you stopping the queue when the ring gets full, am I not looking > > into the right place? Otherwise this is sort of expected to occasionally hapen > > We are calling stop_queue if TX ring is full. Is that what you meant? > netif_stop_queue(ndev); But somewhere else or just here after printing the warning? The recommended flow is to stop the queue after enqueuing a packet successfully, if the remaining space is not enough to hold an skb with all frags populated. That avoids ever returning BUSY. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel