From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 697D5E94133 for ; Fri, 6 Oct 2023 22:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aPqRD6l00ynYpFbwSL8bcsKCWNvufEpL7s3pGwCrAS4=; b=Yi6mgWqRn8Ka/l SKqugzb78qc8pj4lkPUBGIcqFwoJsUhI9k/MdzAaWDhiWJ5FWebdxeYvlLOJjmoCG02p54Xi6+ZFH 2mxrLD8lfk6/FWFUj34WNPMLxXPXeAIKTadZZdMdCU/rFAFuJOI6uJENWGBmQhBxcqPf58ruKSGhv kiT/jmTxmy4JNSRrNiRRyRrtYahVWuD/k4nhAF226Qy1bE7dGwZ1JZ/d/kavkM/1d8jH+ABngpIjT PGtf/mKk5qqvqxu6nFfsYCkmGD/5PxLW+sUzk8/PmRlJVfGeSNEv71tWfIiLEGN7GCvvtBhUyH2kH uM0xjbf8Fe3mxUfxqphA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qosuS-006YlG-00; Fri, 06 Oct 2023 22:03:00 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qosuO-006YkJ-1w for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 22:02:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id D95C7B82ABF; Fri, 6 Oct 2023 22:02:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49C4CC433C7; Fri, 6 Oct 2023 22:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696629774; bh=5qNpTHdPbPHNPOq+CPvh8QULUoFCrWL4op5DAxKIpGM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mr5hNZS7cPEC9fZ9Pm1otMuyEoQtn5x0MebbmvDKT1ysxZd56Xx+tCIEM8QZkQ0Rx 2HUNxrgaPRHz8QjWANUbD1mH6curuCdl6HomjYf2KnrCtmGyAAnY5ufgjcVH8v/6jb QG2jDbcpxxyNYg4G8snQQRAUJZiH1mXGOYt8SQQGeANRY51XoIQTOlWK6yuYXJMFzl JuNX4YzwFq+kxxRqEiTycDfkPmkv5j5xhBajGBUP1pMm0yb+NbugndmWBLihXxE3sN +UAuDIx49s6xJ7b8nNHq77RCfPL2Bx0miv1JSuqRDSCA4eQG0Z9vQ8/jx1890NcVXF fyDg6rJJsfGGg== Date: Fri, 6 Oct 2023 15:02:52 -0700 From: Jakub Kicinski To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20231006150252.6d45be95@kernel.org> In-Reply-To: <20230928070652.330429-27-herve.codina@bootlin.com> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-27-herve.codina@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_150256_796647_BC8FA126 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote: > + for (i = 0; i < count; i++) { > + (audio_devs + i)->name = "framer-codec"; > + (audio_devs + i)->of_compatible = compatible; > + (audio_devs + i)->id = i; Why not array notation? > + } > + > + ret = mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL); Should Lee be CCed for the MFD part? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel