From: Rob Herring <robh@kernel.org>
To: Tanmay Shah <tanmay.shah@amd.com>
Cc: jassisinghbrar@gmail.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, michal.simek@amd.com,
shubhrajyoti.datta@amd.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: zynqmp: add destination mailbox compatible
Date: Fri, 6 Oct 2023 12:53:48 -0500 [thread overview]
Message-ID: <20231006175348.GA4076821-robh@kernel.org> (raw)
In-Reply-To: <20231005170825.3521669-1-tanmay.shah@amd.com>
On Thu, Oct 05, 2023 at 10:08:24AM -0700, Tanmay Shah wrote:
> Current dt-bindings does not contain compatible property
> for child mailbox node. Child mailbox nodes are used
> to represent destination (remote) IPI agents. The compatible
> property for all destination mailboxes must be required.
>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> index aeaddbf574b0..8b15a0532120 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> @@ -74,6 +74,10 @@ patternProperties:
> type: object # DT nodes are json objects
> additionalProperties: false
> properties:
> +
> + compatible:
> + const: xlnx,zynqmp-ipi-dest-mailbox
> +
> xlnx,ipi-id:
> description:
> Remote Xilinx IPI agent ID of which the mailbox is connected to.
> @@ -95,6 +99,7 @@ patternProperties:
> - const: remote_response_region
>
> required:
> + - compatible
A new required property is an ABI break, but nothing about that in the
commit msg.
> - reg
> - reg-names
> - "#mbox-cells"
> @@ -124,6 +129,7 @@ examples:
> ranges;
>
> mailbox: mailbox@ff9905c0 {
> + compatible = "xlnx,zynqmp-ipi-dest-mailbox";
> reg = <0x0 0xff9905c0 0x0 0x20>,
> <0x0 0xff9905e0 0x0 0x20>,
> <0x0 0xff990e80 0x0 0x20>,
>
> base-commit: 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-06 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 17:08 [PATCH 1/2] dt-bindings: zynqmp: add destination mailbox compatible Tanmay Shah
2023-10-05 17:08 ` [PATCH 2/2] dts: " Tanmay Shah
2023-10-06 17:53 ` Rob Herring [this message]
2023-10-06 18:24 ` [PATCH 1/2] dt-bindings: " Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006175348.GA4076821-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox