From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4621DCD68E3 for ; Tue, 10 Oct 2023 02:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6WAf0vghun+eEreK94Lr2N7u1cw7CImptiOc2e4hyXw=; b=MRYnGGq0tCwW2Q MYL/ySQaPIDiAxx18UuzD4zhBH/YQH7hfChkC7qBpAevHZBQVrh2UdPgQZhb7yUc10rG6JVNp9eq3 /CugKEWybBNEL1L+QW3nygZthuJH8lzXFg4eVaFHx5fhbAs5iCKNKXzLuFzNncBLzSQNLJ7SCM73O IEpYYr72pIbV6opKY8llvXLITS55mI3TTwqzCFozfArspjM98D6eZQY2OdOOtUp+uBfLXEa4eAd4T liHzMVwZ0t0fpvzN1x/EeVOlvmlVkkn5Va11lLDh8zfNPtNM8Egg+VLz99d0SNl1xcHZW7GIF+pQi JwRGTlxKQc4GbsUruBPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq2jN-00C90q-2R; Tue, 10 Oct 2023 02:44:21 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qq2jK-00C8ze-2i for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 02:44:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 04EA9CE168C; Tue, 10 Oct 2023 02:44:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D579DC433C8; Tue, 10 Oct 2023 02:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696905856; bh=treVhknigFLOvLPpCX2pJytnQxAJcYhloBwVCamrvGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IVGUsDGjxwI4/Wvc0x8ZoyhgEP/SNfc9W+KHYI/F36mvIr4kp74/xebkuC9HX/QT0 F2TN4bdXvsGV02J6Pobk/QtxodTjx3wqvgQ0akVtNji7nOUM3XActlms/VnJmncbt3 naPrQPgmNL/nwMy3Hm+WRULlLcpJPqr3WE6cvoe20lgBuV43BCGBhyHhO6NOLWmm48 ha3/3dMUUUY3GAPkqg/HG9N8X71t/FEVPmL4fEra7Tk75k68l6/kKC1R++VruzT2l7 RfPpkTkBEw73Bbqashdv1Qjsn9XgPE+kTs56fy9sMmW3dUXzzOL0eqipbamd0aOD3k nyYlwnt36qbPQ== Date: Tue, 10 Oct 2023 10:44:04 +0800 From: Shawn Guo To: Fabio Estevam Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: Re: [PATCH 1/2] ARM: mxs: Add serial: Search for specific ocotp nodes Message-ID: <20231010024404.GP819755@dragon> References: <20231009173740.3535167-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231009173740.3535167-1-festevam@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231009_194419_059381_37B9D834 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 09, 2023 at 02:37:39PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Per mxs-ocotp.yaml, "fsl,ocotp" is not a valid entry. > > "fsl,ocotp" is only used to indicate the location of the > struct device_node that points to the ocotp node. > > Search for the specific "fsl,imx28-ocotp" and "fsl,imx23-ocotp" > instead and remove the undocumented "fsl,ocotp" fallback. Since the compatible is being used, can we document it instead? Shawn > > Signed-off-by: Fabio Estevam > --- > arch/arm/mach-mxs/mach-mxs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c > index 3faf9a1e3e36..d16e638990da 100644 > --- a/arch/arm/mach-mxs/mach-mxs.c > +++ b/arch/arm/mach-mxs/mach-mxs.c > @@ -94,7 +94,9 @@ static const u32 *mxs_get_ocotp(void) > if (once) > return ocotp_words; > > - np = of_find_compatible_node(NULL, NULL, "fsl,ocotp"); > + np = of_find_compatible_node(NULL, NULL, "fsl,imx28-ocotp"); > + if (!np) > + np = of_find_compatible_node(NULL, NULL, "fsl,imx23-ocotp"); > ocotp_base = of_iomap(np, 0); > WARN_ON(!ocotp_base); > > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel