From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C052FCD690B for ; Tue, 10 Oct 2023 08:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=10UCEY51VCXlemhaMZHqI2qpVI2DfSBvSgR9zB/yFcw=; b=r5L5MajDtcr4lg pcNJsdDouGjoLq3cTx1oSSAtlH9L5dL4znDYK6jIHTKvXLb9gqDwfk0sDHPrVHIj6AVGbo8kThb3S KbQdh30oaSOvIjCnFSkb7kMemWQhuScSeC3wJx8HWPV9ZTd4cGG5Ntb3EcPooP3mWddTS7KEeQ2Xl wslwbOE8rIkELjW1rMoZUDbOhNuW7i1qUtHY1nB/noV2X0neGV8l+1U7LkhFIh/b4qWhUFL9meAcU CVNuULI58fQivyti6uWcaXfhf8+zF1AjelBFZa5hZfWjSpoty6NT/Z4l34P/z//bIlsILrCYcgJRp sbBUAUQvCFB3ihy07bdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq8Rd-00Cs8f-0W; Tue, 10 Oct 2023 08:50:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq8Ra-00Cs84-0A for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 08:50:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 52EC71FB; Tue, 10 Oct 2023 01:50:56 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 809C23F762; Tue, 10 Oct 2023 01:50:14 -0700 (PDT) Date: Tue, 10 Oct 2023 09:50:12 +0100 From: Sudeep Holla To: Hanjun Guo , Jean-Philippe Brucker , Robin Murphy Cc: Lorenzo Pieralisi , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, D Scott Phillips Subject: Re: [PATCH] ACPI: bus: Move acpi_arm_init() to the place of after acpi_ghes_init() Message-ID: <20231010085012.qkntexfsph333sif@bogus> References: <20231010082123.4167603-1-guohanjun@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231010082123.4167603-1-guohanjun@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_015022_158173_EB62C7FD X-CRM114-Status: GOOD ( 24.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 10, 2023 at 04:21:23PM +0800, Hanjun Guo wrote: > acpi_agdi_init() in acpi_arm_init() will register a SDEI event, so > it needs the SDEI subsystem to be initialized (which is done in > acpi_ghes_init()) before the AGDI driver probing. > > In commit fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific > initialisation into acpi_arm_init()"), the acpi_agdi_init() was > called before acpi_ghes_init() and it causes following failure: > > | [ 0.515864] sdei: Failed to create event 1073741825: -5 > | [ 0.515866] agdi agdi.0: Failed to register for SDEI event 1073741825 > | [ 0.515867] agdi: probe of agdi.0 failed with error -5 > | ... > | [ 0.516022] sdei: SDEIv1.0 (0x0) detected in firmware. > > Fix it by moving acpi_arm_init() to the place of after > acpi_ghes_init(). > > Fixes: fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific initialisation into acpi_arm_init()") > Reported-by: D Scott Phillips > Signed-off-by: Hanjun Guo > --- > > I did a test on a ARM server and I didn't see regressions, but > I don't have a AGDI table firmware, so Scott please give a > test to see if it fixes your issue. > > drivers/acpi/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index f41dda2d3493..a4aa53b7e2bb 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -1410,10 +1410,10 @@ static int __init acpi_init(void) > acpi_init_ffh(); > > pci_mmcfg_late_init(); > - acpi_arm_init(); > acpi_viot_early_init(); > acpi_hest_init(); > acpi_ghes_init(); > + acpi_arm_init(); I am fine with the change, but just wanted to check with Robin/Jean-Philippe if there are any dependency on IORT initialisation for VIOT ? IIUC IORT was always initialised before VIOT but that changes after this change. If it turns how to have dependency, then does moving GHES and HEST initialisation before acpi_arm_init() work ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel