From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 553FACD691E for ; Tue, 10 Oct 2023 09:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wYqtTQ4bVnuD59PLlhj1XFP8CCMPsJiu5y82v/W7pas=; b=JSvIZTxnG2wpbk Rn/kLntzsCKY0WjRaGvovw2bHgar0DvcxSik2o3nEUjV1hRUaZnLbER6jnIsACXejUxCPDRlJBrHU kZo7vshUolQX+qPQpdxJYIKQgzGOyIo/BDos8xln3YDRC3xtUZPfUuKgmlmLb8gW8yTQ0ChbiEvVq HuKKQtHyCSCkQKOpmXNZ+kqCPRPhKwKobqjwQbXwplMlWl5kaxALKuk8gpCgZOqxx2yzCM6U0ctVo 15PvTEpolTNeMPZF5lKE+KypaXH/Dfy2PD2O6ofPPpxPh9Ll9XRkw/AfgwNh8IO9UddqoylM2pAEH qXduyCe/hC7ayie+TW7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq9ID-00CxsC-1S; Tue, 10 Oct 2023 09:44:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq9I9-00Cxqy-2K for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 09:44:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CD1C1FB; Tue, 10 Oct 2023 02:45:19 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CC953F762; Tue, 10 Oct 2023 02:44:37 -0700 (PDT) Date: Tue, 10 Oct 2023 10:44:35 +0100 From: Sudeep Holla To: Robin Murphy , Hanjun Guo , "Rafael J . Wysocki" Cc: Jean-Philippe Brucker , Lorenzo Pieralisi , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, D Scott Phillips Subject: Re: [PATCH] ACPI: bus: Move acpi_arm_init() to the place of after acpi_ghes_init() Message-ID: <20231010094435.wrdrt4c2gzh7lakh@bogus> References: <20231010082123.4167603-1-guohanjun@huawei.com> <20231010085012.qkntexfsph333sif@bogus> <717a0880-1bc4-461f-bd42-c522d653b3ea@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <717a0880-1bc4-461f-bd42-c522d653b3ea@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_024441_803610_DB0D43DE X-CRM114-Status: GOOD ( 31.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 10, 2023 at 10:30:56AM +0100, Robin Murphy wrote: > On 2023-10-10 09:50, Sudeep Holla wrote: > > On Tue, Oct 10, 2023 at 04:21:23PM +0800, Hanjun Guo wrote: > > > acpi_agdi_init() in acpi_arm_init() will register a SDEI event, so > > > it needs the SDEI subsystem to be initialized (which is done in > > > acpi_ghes_init()) before the AGDI driver probing. > > > > > > In commit fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific > > > initialisation into acpi_arm_init()"), the acpi_agdi_init() was > > > called before acpi_ghes_init() and it causes following failure: > > > > > > | [ 0.515864] sdei: Failed to create event 1073741825: -5 > > > | [ 0.515866] agdi agdi.0: Failed to register for SDEI event 1073741825 > > > | [ 0.515867] agdi: probe of agdi.0 failed with error -5 > > > | ... > > > | [ 0.516022] sdei: SDEIv1.0 (0x0) detected in firmware. > > > > > > Fix it by moving acpi_arm_init() to the place of after > > > acpi_ghes_init(). > > > > > > Fixes: fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific initialisation into acpi_arm_init()") > > > Reported-by: D Scott Phillips > > > Signed-off-by: Hanjun Guo > > > --- > > > > > > I did a test on a ARM server and I didn't see regressions, but > > > I don't have a AGDI table firmware, so Scott please give a > > > test to see if it fixes your issue. > > > > > > drivers/acpi/bus.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > > index f41dda2d3493..a4aa53b7e2bb 100644 > > > --- a/drivers/acpi/bus.c > > > +++ b/drivers/acpi/bus.c > > > @@ -1410,10 +1410,10 @@ static int __init acpi_init(void) > > > acpi_init_ffh(); > > > > > > pci_mmcfg_late_init(); > > > - acpi_arm_init(); > > > acpi_viot_early_init(); > > > acpi_hest_init(); > > > acpi_ghes_init(); > > > + acpi_arm_init(); > > > > I am fine with the change, but just wanted to check with Robin/Jean-Philippe > > if there are any dependency on IORT initialisation for VIOT ? IIUC IORT was > > always initialised before VIOT but that changes after this change. > > They should be independent, and typically we'd only expect to see one or the > other anyway (although strictly a VMM *could* provide virtio-iommu for some > devices while also emulating an SMMU for others if it really really wanted > to). > Thanks Robin for the explanation, that helped me to understand the usage better. Hanjun, In that case, Reviewed-by: Sudeep Holla Rafael, Can you please pick this up as fix for v6.6 if possible ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel