From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 323CDCD98F6 for ; Wed, 11 Oct 2023 07:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MQ9i/KPjB/bwX+0EP166D3ssrXGD5JIIiCkGb0vapd8=; b=4nnmI3FvaCd0yt I7t8BFOrXbSlFRrFqyu1suGcEvnpYyhxa++DYzqJ5onv7Tt8mdnM9pCrBOocxf/wQ7mgGrjABsPQz G2x+F+8OMwFMkBt+npiICuc8eqDsFZD+rChTd4NV7a+iT4Dl9Ss84mC6K8XQL8oZVUejonP693/uI SQtgPCceZyO//P8G7WfrKT7P0sRIrwwpPaAqx4w1M0bKKVruciss2Cmx41FMQPe9lxVXkpytzNMT5 xLYB0IL3h70I5Tebk6wmbIPCJ3R/DQx0il7VntApNc+X8kGiF3corg/O31xvcKDwJXBGq7e0kAFcx rIpRXNMnjGjx0kund/9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqTz2-00F9xV-1k; Wed, 11 Oct 2023 07:50:20 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqTyz-00F9wl-2Z for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 07:50:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B4147CE1F0A; Wed, 11 Oct 2023 07:50:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60242C433C7; Wed, 11 Oct 2023 07:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697010615; bh=dAef0QN1zwq0RlCLm4JgCn8MtOFfI0dxXws8yV0UGmY=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=jr0OwM6+WhUZhFu/W4RdIy/idIaDOEfQhgNsBIoLr2VO5vxAVsMgZJbtI3tGF31Qp 9KCF7sA5lU1v9OBclNoCryyIhaq9WbWBqgtG/8VY86fveNLcGB4WAfwA31ZTwthDKs ZyGMGHpqi6N4L6e+itO49fA7m25evDED8yDBITxw= Date: Wed, 11 Oct 2023 09:50:12 +0200 From: Greg KH To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 17/20] arm64: dts: google: Add initial Google gs101 SoC support Message-ID: <2023101112-essence-vocalist-857e@gregkh> References: <20231010224928.2296997-1-peter.griffin@linaro.org> <20231010224928.2296997-18-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231010224928.2296997-18-peter.griffin@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_005018_007966_8ADC6EFB X-CRM114-Status: UNSURE ( 7.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 10, 2023 at 11:49:25PM +0100, Peter Griffin wrote: > + serial_0: serial@10a00000 { > + compatible = "google,gs101-uart"; You use this entry, but: > + reg = <0x0 0x10a00000 0xc0>; > + reg-io-width = <4>; > + samsung,uart-fifosize = <256>; See, it's really the samsung IP block. Please don't declare new compatible entries when you don't need to, it just adds churn to the kernel for no reason (and makes you do more work.) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel