From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BEC9CD6E5C for ; Wed, 11 Oct 2023 11:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Li/9k6MCYRfK99ztXIN/Ho2DLISmmJ2r2BFPZpTgSS8=; b=cjWIhSvUfE0DEP wQ2EXCSAW/QZORWzvqZ7JRySMY8gx0HaYs4z0VSw1mtwXOaKfwXvAvPADGer4pEEiWIWEeugJKVAl PyEw/C/GNqVfneuY+VwZyMCJeCZv79G/NiCqHtR7vLmX+tV1Vv4VNIeN4NTrCc2Ri+ESDonAhglCn wupFMAbgrCF5dLs4ZUje/nAXim1UKHnEOOerZr4vk4ydiMHtlc09sIQXlEgzeEmwH/nmZmlezuKEy JLWVynYKiSNMZbJL2qSL5qFeV/Hf00Zo+lf06dhNPJB19y3NSZ6diDrMkppbuCZVgox86MwOFdTGu xBtSViYB2Kt1pFuQ+qnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqXGq-00Fjwa-0I; Wed, 11 Oct 2023 11:20:56 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqXGm-00Fjvc-2q for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 11:20:54 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S59J648TXz6K61b; Wed, 11 Oct 2023 19:18:46 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 12:20:46 +0100 Date: Wed, 11 Oct 2023 12:20:45 +0100 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Thierry Reding , , Alexandre Belloni , Florian Fainelli , Claudiu Beznea , , Subject: Re: [PATCH 02/11] pwm: atmel-tcb: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Message-ID: <20231011122045.00000500@Huawei.com> In-Reply-To: <20231010075112.755178-3-u.kleine-koenig@pengutronix.de> References: <20231010075112.755178-1-u.kleine-koenig@pengutronix.de> <20231010075112.755178-3-u.kleine-koenig@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_042053_064218_E8CCA05F X-CRM114-Status: GOOD ( 19.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 10 Oct 2023 09:51:03 +0200 Uwe Kleine-K=F6nig wrote: > This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to > care about when the functions are actually used, so the corresponding > #ifdef can be dropped. > = > Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM > isn't enabled. > = > Signed-off-by: Uwe Kleine-K=F6nig Reviewed-by: Jonathan Cameron I did a lot of these so I still have how it works fresh in my mind making review hopefully easy :) > --- > drivers/pwm/pwm-atmel-tcb.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > = > diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c > index c00dd37c5fbd..a2be4cb4c073 100644 > --- a/drivers/pwm/pwm-atmel-tcb.c > +++ b/drivers/pwm/pwm-atmel-tcb.c > @@ -490,7 +490,6 @@ static const struct of_device_id atmel_tcb_pwm_dt_ids= [] =3D { > }; > MODULE_DEVICE_TABLE(of, atmel_tcb_pwm_dt_ids); > = > -#ifdef CONFIG_PM_SLEEP > static int atmel_tcb_pwm_suspend(struct device *dev) > { > struct atmel_tcb_pwm_chip *tcbpwm =3D dev_get_drvdata(dev); > @@ -523,16 +522,15 @@ static int atmel_tcb_pwm_resume(struct device *dev) > = > return 0; > } > -#endif > = > -static SIMPLE_DEV_PM_OPS(atmel_tcb_pwm_pm_ops, atmel_tcb_pwm_suspend, > - atmel_tcb_pwm_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(atmel_tcb_pwm_pm_ops, atmel_tcb_pwm_susp= end, > + atmel_tcb_pwm_resume); > = > static struct platform_driver atmel_tcb_pwm_driver =3D { > .driver =3D { > .name =3D "atmel-tcb-pwm", > .of_match_table =3D atmel_tcb_pwm_dt_ids, > - .pm =3D &atmel_tcb_pwm_pm_ops, > + .pm =3D pm_ptr(&atmel_tcb_pwm_pm_ops), > }, > .probe =3D atmel_tcb_pwm_probe, > .remove_new =3D atmel_tcb_pwm_remove, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel