From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F399BCD6E5C for ; Wed, 11 Oct 2023 11:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HrjWTZfFwbT5ZHfh8My4pszo3SIm+mwJMN5EvLOmZ3Q=; b=fLCVP1aTsYphon zLl9ruMBwH7xphttBKk2VHOJLE+o1Ib6QfCIbsAXhbzTZNtsPVEX+243xrS2NBGTKEU3jPfgu0NGN 90WQbQCy1LWCdNHN3e7XaimwLLZkLvbsmJBOR5C8qpDeiBRqQHPdOlOszHD1c5EOeKtr4qWIzNles K8B1zA1OJH1ymdu/ehZVZTf/j74dHrILGhWoloNAWZ9AW4+d5kP+p5OOCNnH0zL+gwylR/CWPdFaG e8GCxK8YAxv7oXVSKDEhOOdUNGw+oAIDHHcGeSJOXBGquawImM/E+f9OkhmQdu9n4XVaYxlIFLdEL XU+lJ3Smks4Fj/0aclaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqXR9-00Fl6v-0i; Wed, 11 Oct 2023 11:31:35 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqXR4-00Fl66-2g for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 11:31:33 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S59ZJ0pD6z6K5Wx; Wed, 11 Oct 2023 19:31:04 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 12:31:24 +0100 Date: Wed, 11 Oct 2023 12:31:23 +0100 From: Jonathan Cameron To: Konstantin Aladyshev CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 1/3] ipmi: Move KCS headers to common include folder Message-ID: <20231011123123.00000394@Huawei.com> In-Reply-To: <20231010122321.823-2-aladyshev22@gmail.com> References: <20231010122321.823-1-aladyshev22@gmail.com> <20231010122321.823-2-aladyshev22@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_043131_159184_55CAE698 X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 10 Oct 2023 15:23:19 +0300 Konstantin Aladyshev wrote: > The current KCS header files can be utilized by both IPMI drivers > (drivers/char/ipmi) and MCTP driver (drivers/net/mctp). To be able to > use them in both cases move the headers to 'include/linux' folder. > > Signed-off-by: Konstantin Aladyshev Not particularly important but I wonder if include/linux/kcs/bmc.h include/linux/kcs/bmc_client.h include/linux/kcs/bmc_device.h might be a cleaner choice given that you are moving them. I don't care that much though so up to you :) Jonathan > --- > drivers/char/ipmi/kcs_bmc.c | 8 +++----- > drivers/char/ipmi/kcs_bmc_aspeed.c | 3 +-- > drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 2 +- > drivers/char/ipmi/kcs_bmc_npcm7xx.c | 2 +- > drivers/char/ipmi/kcs_bmc_serio.c | 2 +- > {drivers/char/ipmi => include/linux}/kcs_bmc.h | 0 > {drivers/char/ipmi => include/linux}/kcs_bmc_client.h | 3 +-- > {drivers/char/ipmi => include/linux}/kcs_bmc_device.h | 3 +-- > 8 files changed, 9 insertions(+), 14 deletions(-) > rename {drivers/char/ipmi => include/linux}/kcs_bmc.h (100%) > rename {drivers/char/ipmi => include/linux}/kcs_bmc_client.h (97%) > rename {drivers/char/ipmi => include/linux}/kcs_bmc_device.h (96%) > > diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c > index 8b1161d5194a..d29a8505d6ed 100644 > --- a/drivers/char/ipmi/kcs_bmc.c > +++ b/drivers/char/ipmi/kcs_bmc.c > @@ -5,15 +5,13 @@ > */ > > #include > +#include > +#include > +#include > #include > #include > #include > > -#include "kcs_bmc.h" > - > -/* Implement both the device and client interfaces here */ > -#include "kcs_bmc_device.h" > -#include "kcs_bmc_client.h" > > /* Record registered devices and drivers */ > static DEFINE_MUTEX(kcs_bmc_lock); > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index 72640da55380..3dc0dfb448f5 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -21,8 +22,6 @@ > #include > #include > > -#include "kcs_bmc_device.h" > - > > #define DEVICE_NAME "ast-kcs-bmc" > > diff --git a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c > index cf670e891966..bf1001130a6c 100644 > --- a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c > +++ b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -17,7 +18,6 @@ > #include > #include > > -#include "kcs_bmc_client.h" > > /* Different phases of the KCS BMC module. > * KCS_PHASE_IDLE: > diff --git a/drivers/char/ipmi/kcs_bmc_npcm7xx.c b/drivers/char/ipmi/kcs_bmc_npcm7xx.c > index 7961fec56476..160553248a93 100644 > --- a/drivers/char/ipmi/kcs_bmc_npcm7xx.c > +++ b/drivers/char/ipmi/kcs_bmc_npcm7xx.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -17,7 +18,6 @@ > #include > #include > > -#include "kcs_bmc_device.h" > > #define DEVICE_NAME "npcm-kcs-bmc" > #define KCS_CHANNEL_MAX 3 > diff --git a/drivers/char/ipmi/kcs_bmc_serio.c b/drivers/char/ipmi/kcs_bmc_serio.c > index 1793358be782..24df7144a189 100644 > --- a/drivers/char/ipmi/kcs_bmc_serio.c > +++ b/drivers/char/ipmi/kcs_bmc_serio.c > @@ -5,12 +5,12 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > > -#include "kcs_bmc_client.h" > > struct kcs_bmc_serio { > struct list_head entry; > diff --git a/drivers/char/ipmi/kcs_bmc.h b/include/linux/kcs_bmc.h > similarity index 100% > rename from drivers/char/ipmi/kcs_bmc.h > rename to include/linux/kcs_bmc.h > diff --git a/drivers/char/ipmi/kcs_bmc_client.h b/include/linux/kcs_bmc_client.h > similarity index 97% > rename from drivers/char/ipmi/kcs_bmc_client.h > rename to include/linux/kcs_bmc_client.h > index 6fdcde0a7169..f6350c9366dd 100644 > --- a/drivers/char/ipmi/kcs_bmc_client.h > +++ b/include/linux/kcs_bmc_client.h > @@ -5,8 +5,7 @@ > #define __KCS_BMC_CONSUMER_H__ > > #include > - > -#include "kcs_bmc.h" > +#include > > struct kcs_bmc_driver_ops { > int (*add_device)(struct kcs_bmc_device *kcs_bmc); > diff --git a/drivers/char/ipmi/kcs_bmc_device.h b/include/linux/kcs_bmc_device.h > similarity index 96% > rename from drivers/char/ipmi/kcs_bmc_device.h > rename to include/linux/kcs_bmc_device.h > index 17c572f25c54..65333b68c0af 100644 > --- a/drivers/char/ipmi/kcs_bmc_device.h > +++ b/include/linux/kcs_bmc_device.h > @@ -5,8 +5,7 @@ > #define __KCS_BMC_DEVICE_H__ > > #include > - > -#include "kcs_bmc.h" > +#include > > struct kcs_bmc_device_ops { > void (*irq_mask_update)(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 enable); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel