From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89BB4CD6E53 for ; Wed, 11 Oct 2023 09:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3s4UyI/WLlaQzPkzYHpLnC3n+3pm4tQl1Hw1KmO7mNo=; b=ost5pRblcJcwmH boPMogj153frghkWcYj9fv0X8Rqy+8+VOtS0+KJ9EgHT3AXa8xSwjSvqjddiwjjOOUhcbKYAl967m yn8sSbcQGlb8jEY70WRvGkO5ogtFI4HuK1/juWSl/mzJ9s1B6xYmCCPAjcLoY0JVpkeeTbcrLLd4g D000H4L1ftSNyTp0ob5s5l07XUJ9AMnhzustz9BpnS5YA2K19dwKCwRvTLgJQkivsif3VBKI7iOS2 LJnhDIRdIFczYvZ9EKXFWPC5UONP8k2yCMRgWKryc+EWMSxhxDBSLoJkXuqUwQXwOZa5eZt8Zv2GI t0sO5lKATMQDUDZBwtNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqVjm-00FMqS-12; Wed, 11 Oct 2023 09:42:42 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqVjg-00FMnm-1N for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 09:42:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 42817CE2357; Wed, 11 Oct 2023 09:42:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2CADC433C9; Wed, 11 Oct 2023 09:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697017352; bh=I6BUDFXTqdP5QiIJSn6tklq61ipwC+Dq6rKwc18P91U=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=aVFyjUF/hpsF7z0Z4dqSATlUj9NlaJXZyniaMXQG931Cy+ZYAtRpdz3DXYxAXFybG +3h1C5+Kg3QLnh0GzK6NPpz5yWZVVP1uhYdhex6pb2gKI1CK/Z3u1TIK8LBlBym4iE K5mp/ed7lrHq86kcy9LD7LfvJkYqEp1JJ8Ea2IFY= Date: Wed, 11 Oct 2023 11:42:29 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Tudor Ambarus , Peter Griffin , Rob Herring , krzysztof.kozlowski+dt@linaro.org, Michael Turquette , Conor Dooley , Stephen Boyd , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Olof Johansson , Chanwoo Choi , andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, William McVicker , soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 08/20] dt-bindings: serial: samsung: Add google-gs101-uart compatible Message-ID: <2023101126-stash-manor-7162@gregkh> References: <20231010224928.2296997-1-peter.griffin@linaro.org> <20231010224928.2296997-9-peter.griffin@linaro.org> <2023101111-banknote-satin-1f77@gregkh> <2023101137-fester-rerun-5c39@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_024236_830499_768A8B97 X-CRM114-Status: GOOD ( 32.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 11, 2023 at 11:30:25AM +0200, Arnd Bergmann wrote: > On Wed, Oct 11, 2023, at 10:57, Greg KH wrote: > > On Wed, Oct 11, 2023 at 09:49:07AM +0100, Tudor Ambarus wrote: > >> On 10/11/23 08:48, Greg KH wrote: > >> > On Tue, Oct 10, 2023 at 11:49:16PM +0100, Peter Griffin wrote: > >> >> Add dedicated google-gs101-uart compatible to the dt-schema for > >> >> representing uart of the Google Tensor gs101 SoC. > >> >> > >> >> Signed-off-by: Peter Griffin > >> >> --- > >> >> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++ > >> >> 1 file changed, 2 insertions(+) > >> >> > >> >> oneOf: > >> >> - items: > >> >> + - const: google,gs101-uart > >> >> - const: samsung,exynosautov9-uart > >> >> - const: samsung,exynos850-uart > >> >> - enum: > >> >> - apple,s5l-uart > >> >> - axis,artpec8-uart > >> >> + - google,gs101-uart > >> > > >> > These shouldn't be needed, just declare the device as the same as what > >> > >> We should have SoC specific compatibles so that any further quirks or > >> incompatibilities can be easily addressed. > > > > "further" work on quirks or incompatibilities can be added when they are > > found and needed. We don't add stuff for no good reason to the kernel. > > > >> It's not only the IP itself > >> that can differ, it's also the integration of the IP into the final > >> product that could have an influence on the behavior. > > > > This is for the Pixel 6, a device that is no longer even shipping. The > > "final product" is long stable, so this should not be an issue. > > The driver does have soc specific settings for each compatible > string, in this case it looks like it overrides the FIFO size > based on driver specific data and the order in which the > ports are probed [1]. I don't understand why the driver does > this, but my impression is that if we wanted to change it to no > longer rely on that data, we'd also need a new compatible > string. As I reviewed that patch already, it is just duplicating an existing quirk/device that the driver already supports, so there is no need for any "new device type" to be added to that driver, just use the existing hardware description in the dt and all should be fine. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel