From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3667CDB47E for ; Thu, 12 Oct 2023 13:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YJnOQCn4c3BO4sE1cVWsT5qtMLOt0ebdV5tR2eSf2fw=; b=a3nc79MIqqMD4e E91wXD8kF3ziXfbliftVLe0Mea3Z3ETiN5KHQ/Hp4BFSZPAS1jMU2CLGBHlSh49yov2noMzZLyran RxEEuGeKdZOmJmTFu20OZ/ADt5Y365zrZ4NWAp55wxQjUZxhl4s5wGRKD/2PZlF9ZMrTzZ1bnqRp3 +XnrgRJbcU8mg0t9Ig8s2DTcReCP5kPWn8mpt/FjpdpisZ7yQJiUyybWNPolaJkt/ZeChshaOMzKp FUvEcp6pv+rU52Zx8fOsFVwoROUDbl0i7FKDN34trv6yrXAi5JISMjJLZZan81qhVawOkSWj8eJCU 4eF0jeyrYDUnr9dr5KFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqvcX-00145s-0a; Thu, 12 Oct 2023 13:20:57 +0000 Received: from mail-bn7nam10on20629.outbound.protection.outlook.com ([2a01:111:f400:7e8a::629] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqvcU-00145L-16 for linux-arm-kernel@lists.infradead.org; Thu, 12 Oct 2023 13:20:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N3FbMY3bf+fbyiuWjIFsZRM4hZh6LymOIA6N1Wkw1wZYf0jM0Wb+NKq5mle2cri5xh9lmyM4fu7p9Z+RB+JMLJllwyuFwt8eWT8e2jUrbhcpdJbyQDu6YNTM+k7V10EWUvWor2DLxe8830Zu5Xya66R42S6uXeVzlrgXnAQ6jqz/Xt3n1X0MVXAfKbGUscpaZFDiZfM74v03yEOwWmwRga5O/YLYAPMMXEPBjPE4z7z8jTfR0GRiiC1HzRXdeJsMCcOxvN8pOx6yi0GSA78nlwcsfqDMUu6ohaF0Y934J6Aeq61DRrO90EQEscscEY0PbCRP02tfJONbPubT+8fOlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SJJZKw4QXyxsVV++w8/o0cUom9IRcKIploB9B9mG+ps=; b=M6qdYyGIViyR3qWsyU/xNWlBDuChXSdV3rUOfld7QuRwRyxJOXJNtNtauHbLxkVhrGp4sQnjIu6l5lAPCeZpnJ0PBdc7hsKPLg0AZDfbFNjdKoX6HXwVcpp1a69xTLdht33m3hZ780pza47DSeCOhjQkLgAo6sKjztUiRO8Lnz9Cq4iVWOs7WgAhZIREXIJa5vodnf/pBNkKUjgmZCafF2eqgG1q50yt3Gw2j295xkZxB/Fy8YjSyO1rmkVjiJVkwEHv8QJAA92Uhs8BOpQwzD7QsbPEiqKnjX6weW4W/sbYlGz+6QnzCHX3T+XSuOKiJp+ose35RdBcQjuhLPgNyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SJJZKw4QXyxsVV++w8/o0cUom9IRcKIploB9B9mG+ps=; b=aTBzIoVetvW21P3i0Yj4yb9DKVATzUKUT/KoW+98umI57wgENP5wEstkFDEyryjcK8qXzphatdoazJOV2ItZN/SkOWlU+pi/h8NZeMBI4sagruewq8jcjjg1gEBqq/3XTY+b7mclLttRrTckdMFWOoR3bUXoJq4DTT1WU/PJm314Ed5k9gAwSMkjNLpsf0zGc5AqFrfHI02B0W1BA9I7QuzbvrSvP4tgNXJV8KsSR6YdAOmBFVnEK7Q0ffgQ8KCGsdOgQB4USS69CyvtR1u8WMVA8WsJkkIjscNA3qtrSqaLAZ5Rve3DTc2ptMqhIKfOVGLWxas5f7p2tnOXycRSuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by PH7PR12MB6395.namprd12.prod.outlook.com (2603:10b6:510:1fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 13:20:46 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3f66:c2b6:59eb:78c2]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3f66:c2b6:59eb:78c2%6]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 13:20:46 +0000 Date: Thu, 12 Oct 2023 10:20:45 -0300 From: Jason Gunthorpe To: Will Deacon Cc: Lorenzo Pieralisi , Catalin Marinas , ankita@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] KVM: arm64: allow the VM to select DEVICE_* and NORMAL_NC for IO memory Message-ID: <20231012132045.GI3952@nvidia.com> References: <20230907181459.18145-1-ankita@nvidia.com> <20230907181459.18145-3-ankita@nvidia.com> <20231012123541.GB11824@willie-the-truck> Content-Disposition: inline In-Reply-To: <20231012123541.GB11824@willie-the-truck> X-ClientProxiedBy: MN2PR22CA0014.namprd22.prod.outlook.com (2603:10b6:208:238::19) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|PH7PR12MB6395:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cfd1de2-4754-406f-0437-08dbcb260b5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r+iChhI+V4DWAie3sH43wUZHC+/67UDW94hOu3saZetfnY489OBi4NCFi9p3w+g16Xpme5R5e7lkcD6IWfFOCsr6i3gV/f+kMIzNre+4E0NYm8I2q+SQjjuR9bv6AM+Tqfji9gayXuvAkfz7f8y6JemgCFWKGhY5f2sUdaPESEBuFqm7MffCawXOdExjlCR03kNpeqskNJRMXHBVGymLag33qpFdHqvz6raq6lI/EUFCAESgzOA+yoENqurgA6YLOMCLBXHlBagjdxGP+SGOJMcmAynCq1PkkrRuetLjcBPCAdLcEL3xO8/P99a+TTwKbW1VMmaTCNCGBtBH9rOZ1LvaxN5VmYak4JUtdSKVYDnvdZ4IbXeFD9A1qxFDZ8Cu4Cq+JFiKOS2jLitXApNIrQol7a0uBDdeSvtPWBLzyHzrJt2Y5YvUXLDYQXc6RPp78daKHm8p6LVcUVZhgX0D6VvadVHO2e78ONpPdSC9g/DfC3x73sZO3R5f3+ondGPd6g5n+l/LdxOeHCoVjbO593CY4lbVLiUQsnvoEJukLIRlrMmVWqAqmXVA5tS3sp2A X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(376002)(396003)(366004)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(1076003)(2616005)(6512007)(36756003)(33656002)(86362001)(38100700002)(26005)(2906002)(83380400001)(6486002)(6506007)(478600001)(8936002)(8676002)(4326008)(6916009)(316002)(41300700001)(66556008)(66946007)(54906003)(66476007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QEmzUlXwxliFfPfi+RTaaI6R6FEWrTZhryi0cIQdoNjxeBb/rXVgXiyjX849?= =?us-ascii?Q?15HgrTJOPJxjeVTYqE+A9r20v5hCJf3Y/cHL9fjfycQ2NeBqJsjI+l6dLmGX?= =?us-ascii?Q?slJOx3jwjAceoDUAk4C/4u1aMkLSX+WSjifdf12rURGC0+8JA1g9A4YwJSQM?= =?us-ascii?Q?Ilr/RS/WqvaV02AqYM5MqlgG79XkMS9Ft5phgb3ioe/eht9TzJxjmyy0kdKy?= =?us-ascii?Q?o4NXgb1/qgrVgOR/Jq95cnnsezsXRdlW21CZ0BA4Qnk3BWOk8mYlrtjiBUmZ?= =?us-ascii?Q?Pd6wk0GhLaMdLMg7xqSRwnvKLl9Evd2MFtCfesdlkum/2m/l0OvTK3RRRZff?= =?us-ascii?Q?aM2cj8VOi+6uKBoZVPO1xT58oSKM3vv7jRORkoDNVXydChvyYycYEzb/9Ps5?= =?us-ascii?Q?PdfrfFBDIn2LakygQLWucSGk83iZ/YT5qJpsFnSoAaqy5LE4LoeuONf3445q?= =?us-ascii?Q?wFujABN9bAPxFwwZEkBNKMSUo8HH2LGvsylD1014wvXHrW7USXLZbYyk6eUW?= =?us-ascii?Q?3FpD6teHkE7ddp+B7jUtEeUSnLNUMVmfzr2w6jTnBHfUlpJuJ9DYZdGL3yFT?= =?us-ascii?Q?Ct35HHb23IheGPJI/ZQ88E36VND2e7HTsRJ8lHlBSbK29YX4QQdQKLLMg8BD?= =?us-ascii?Q?pSNPKhaYQsCa0BriezcNDSvJJhqb15AftzjKRsYzWHccxTocjbxAdjPDEU7d?= =?us-ascii?Q?cPfb3bzTM4sbx0h/6LQrVio9ZMs8X0DHA9mcC2e4kDsQc8f6Fr6vgjfaJVyx?= =?us-ascii?Q?k5GE3xWDNY1YBjd1RCQcXLw5n45LDTPApg0Nycy29i/PvQPxL57wDh88XJ3v?= =?us-ascii?Q?oPLvvkmQ9l8HoEV+N9djlfRv6t/2PH3AHoJl9FhQtc/ueFi1mYyJ1+ToHqcH?= =?us-ascii?Q?xdBhmaYC54kf6FOZJqzOUhFr4TShw7K63oQsqrAjtMRc0CnC/jG1C/osb7JM?= =?us-ascii?Q?1y426nvoS92XJDzCgBS/xIjzpzRk6ucr+c/baE2FMa1zZ8wOgz0rhMCa8kIE?= =?us-ascii?Q?eQ1OOIxMQIoMUvXnihI+rD+Opv8dVsGC+YNnmBAS2wV3u5o5vhnsHmxZUQay?= =?us-ascii?Q?LUI7ZO1YbqT5cTyoXDUuaANqWK2YB9njgFqsGMB3LeoWK+aIiwZACuQGbIUz?= =?us-ascii?Q?1MoPn9lo2A5d0RaWcQupiBNW51GWmGbEZZ4UwGzqRJ51+vRWTUsmT5b9cn3X?= =?us-ascii?Q?adfq1YpQroh22jTRBohB2bl4/9yBIo8Rd2pI3pHu4V8pn1XRgqjp+SdRBnAQ?= =?us-ascii?Q?TMWPo1BmH90usgRgpq2vpohDZYLUnrpUOgS6sWAlm1qNNAtMdBjuBuTesg8I?= =?us-ascii?Q?mL/6NZKXlyElEVB1V3KCFHY5lQiDaFjfoM8kp70Wa6wPIQfYC8TBQ4BRK97x?= =?us-ascii?Q?VUqcOPiyHZ6ZIIyJMKN7XUlyhewD31450R55RMBN1Nb2Y181NNOpw5n3PEXI?= =?us-ascii?Q?uFPiP2uO6v9t0kBaxCVmIiBoyut9Ma+U5mHO0tERq2mz1+uMY72Y1/SOOR8b?= =?us-ascii?Q?h6MZJAsBuftkDS5VHj9ahRwCzTP/Vg9NSkOsuYVpw+y1qAGiVtvOBuhPo7UK?= =?us-ascii?Q?nM+VOE5GifE+qcjyk0AUBdj+0lkmwuexX1ZC0ks8?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cfd1de2-4754-406f-0437-08dbcb260b5c X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 13:20:46.4146 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gxHZva/Xtq4yRA3ltfafgX1EUWNHtGlGOlvL2K0jNhkbn4+tW7SumhkJDwGpgdvl X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6395 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_062054_457221_33359903 X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 12, 2023 at 01:35:41PM +0100, Will Deacon wrote: > > Failures containability is a property of the platform > > and is independent from the memory type used for MMIO > > device memory mappings (ie DEVICE_nGnRE memory type is > > even more problematic than NormalNC in terms of containability > > since eg aborts triggered on loads cannot be made synchronous, > > which make them harder to contain); this means that, > > regardless of the combined stage1+stage2 mappings a > > platform is safe if and only if device transactions cannot trigger > > uncontained failures; reworded, the default KVM device > > stage 2 memory attributes play no role in making device > > assignment safer for a given platform and therefore can > > be relaxed. > > > > For all these reasons, relax the KVM stage 2 device > > memory attributes from DEVICE_nGnRE to NormalNC. > > The reasoning above suggests to me that this should probably just be > Normal cacheable, as that is what actually allows the guest to control > the attributes. So what is the rationale behind stopping at Normal-NC? I agree it would be very nice if the all the memory in the guest could just be cachable and the guest could select everything. However, I think Lorenzo over stated the argument. The off-list discussion was focused on NormalNC for MMIO only. Nobody raised the idea that cachable was safe from uncontained errors for MMIO. I'm looking through the conversations and I wouldn't jump to concluding that "cachable MMIO" is safe from uncontained failures. Catalin has already raised a number of conerns in the other patch about making actual "designed to be cachable memory" into KVM cachable. Regards, Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel