From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] RFC: net: dsa: mv88e6xxx: Register mdio-external
Date: Fri, 13 Oct 2023 09:15:50 -0500 [thread overview]
Message-ID: <20231013141550.GA3793553-robh@kernel.org> (raw)
In-Reply-To: <20231013-marvell-88e6152-wan-led-v1-3-0712ba99857c@linaro.org>
On Fri, Oct 13, 2023 at 12:35:16AM +0200, Linus Walleij wrote:
> Make it legal to have a subnode just named "mdio-external"
> and have that be recognized immediately as the external
> MDIO bus, register it and return. Only fallback to the
> old method with a compatible in the external bus node
> if this doesn't work.
>
> This is the result of deprecating the old DT method
> of providing a node "mdio1" with a compatible string.
I think this is the wrong direction. Using compatible is much better
than relying on node names. We've been "fixing" node names precisely
because they are usually not ABI.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-13 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 22:35 [PATCH 0/3] Create a binding for the Marvell MV88E6xxx DSA switches Linus Walleij
2023-10-12 22:35 ` [PATCH 1/3] ARM: dts: marvell: Fix some common switch mistakes Linus Walleij
2023-10-12 22:35 ` [PATCH 2/3] RFC: dt-bindings: marvell: Rewrite in schema Linus Walleij
2023-10-13 12:43 ` Andrew Lunn
2023-10-13 13:04 ` Linus Walleij
2023-10-13 14:18 ` Rob Herring
2023-10-13 15:40 ` Andrew Lunn
2023-10-12 22:35 ` [PATCH 3/3] RFC: net: dsa: mv88e6xxx: Register mdio-external Linus Walleij
2023-10-13 12:45 ` Andrew Lunn
2023-10-13 14:15 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013141550.GA3793553-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).