From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0736CCDB465 for ; Sat, 14 Oct 2023 14:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fxHvsATo8Jxh4TKAs4XouHPcYhCp6b63wEomedoBdlI=; b=NAAql+4deZFY9Q c6vtaD6l6V6lVUGUDh2bA/KSc3XxNKiG+3g/wX3+uF2n4l0M9wHH2qavmwP2vFia85Lvsad8oRBr2 XdT53otaQ8KRsogdTDgD/o5JM6G15/Ug2D7enlwOmh08hUTDWaFAC/ztSK0xMrQkdxWfkhf32jp+0 oCw0jgWn/fy3ogi8hTRzwnwzxCkNFUQtSjMjfKXh8KrOkc3w9QSY4ovEhcqfRZySiJkc5pxNDS8rf eggtHA0Wfoky4U4/LpVynoYLKZyRX8tPdFo2hcIZxY4+YQmBC5tw7Sa2mp/tY9iIUNs+ovtHVLylT GzyURoY/qXCnHRIxwPUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrfsi-005TtX-1d; Sat, 14 Oct 2023 14:44:44 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrfsc-005TrU-2Q for linux-arm-kernel@lists.infradead.org; Sat, 14 Oct 2023 14:44:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id E1D5BB8076B; Sat, 14 Oct 2023 14:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 638DCC433C7; Sat, 14 Oct 2023 14:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697294673; bh=11scpju71D+KerC5FhLxK9Ma2HRBqYwq2VHa/P5HXo8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tb40Oyx8m0AwzPXsLNlWOiSigEbsAvCNBdUpb2hrFWsFqQCrASeDhLRd7HQzzg0ev LySdTO04dtwnNoNrNM0z2C02dwhFNeXDWP0Npm+pw3FKK07TdejIZJQOnPeqelqVsR 8b05MV4RpV1yiNOw6N2VlGGRzEzJfC+imxNtvnA4AYo8xPvQvvsybNz5CqurNrjd96 xD4vdsOEmP25fCCGy8pMoFd8k7Nj1ebREcJgHyXIR7Y1W6HHW1bW+Oa/Fs3n8FUNky neYAProozhcaz3AqZxalAfVITm/Y/AZKf2cRlXMPUNYjoapEk+JnLjKWEGhnbVS6TG 791CflIJO8iTw== Date: Sat, 14 Oct 2023 16:44:28 +0200 From: Simon Horman To: Johannes Zink Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Richard Cochran , Kurt Kanzenbach , patchwork-jzi@pengutronix.de, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Message-ID: <20231014144428.GA1386676@kernel.org> References: <20231010-stmmac_fix_auxiliary_event_capture-v1-0-3eeca9e844fa@pengutronix.de> <20231010-stmmac_fix_auxiliary_event_capture-v1-2-3eeca9e844fa@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231010-stmmac_fix_auxiliary_event_capture-v1-2-3eeca9e844fa@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231014_074439_125617_2001DC87 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 12, 2023 at 11:02:13AM +0200, Johannes Zink wrote: > The stmmac supports up to 4 auxiliary snapshots that can be enabled by > setting the appropriate bits in the PTP_ACR bitfield. > > Previously instead of setting the bits, a fixed value was written to > this bitfield instead of passing the appropriate bitmask. > > Now the correct bit is set according to the ptp_clock_request.extts_index > passed as a parameter to stmmac_enable(). > > Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping") > Signed-off-by: Johannes Zink Hi Johannes, The fix language of the subject and presence of a fixes tag implies that this is a bug fix. But it's not clear to me that this is resolving bug that manifests as a problem. If it is a bug fix then it should probably be targeted at 'net', creating a dependency for the remainder of this series. On the other hand, if it is not a bug fix then perhaps it is best to update the subject and drop the Fixes tag. I'm no expert on stmmac, but the rest of the series looks good to me. ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel