Re: [PATCH 6.5 006/191] arm_pmu: acpi: Add a representative platform device for TRBE

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Oct 16, 2023 at 06:05:53PM +0200, Thorsten Leemhuis wrote:
> On 16.10.23 10:39, Greg Kroah-Hartman wrote:
> > 6.5-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Anshuman Khandual <anshuman.khandual@arm.com>
> > 
> > [ Upstream commit 1aa3d0274a4aac338ee45a3dfc3b17c944bcc2bc ]
> > 
> > ACPI TRBE does not have a HID for identification which could create and add
> > a platform device into the platform bus. Also without a platform device, it
> > cannot be probed and bound to a platform driver.
> > 
> > This creates a dummy platform device for TRBE after ascertaining that ACPI
> > provides required interrupts uniformly across all cpus on the system. This
> > device gets created inside drivers/perf/arm_pmu_acpi.c to accommodate TRBE
> > being built as a module.
> > 
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> > Link: https://lore.kernel.org/r/20230817055405.249630-3-anshuman.khandual@arm.com
> > Signed-off-by: Will Deacon <will@kernel.org>
> > Stable-dep-of: 4785aa802853 ("cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer")
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Got a compiler error when using Fedora's stable kernel config and
> compiling 6.5.8-rc1 for ARM64; not totally sure, but from the error msg
> I suspect it's caused by the change quoted above.
> 
> """
> + /usr/bin/make -s 'HOSTCFLAGS=-O2  -fexceptions -g
> -grecord-gcc-switches -pipe -Wall -Werror=format-security
> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
> -mbranch-protection=standard -fasynchronous-unwind-tables
> -fstack-clash-protection' 'HOSTLDFLAGS=-Wl,-z,relro -Wl,--as-needed
> -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1
> -specs=/usr/lib/rpm/redhat/redhat-package-notes' ARCH=arm64 'KCFLAGS= '
> WITH_GCOV=0 -j4 vmlinuz.efi
> drivers/perf/arm_pmu_acpi.c: In function 'arm_trbe_acpi_register_device':
> drivers/perf/arm_pmu_acpi.c:164:19: error: implicit declaration of
> function 'arm_acpi_register_pmu_device'; did you mean
> 'arm_spe_acpi_register_device'? [-Werror=implicit-function-declaration]
>   164 |         int ret = arm_acpi_register_pmu_device(&trbe_dev,
> ACPI_MADT_GICC_TRBE,
>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                   arm_spe_acpi_register_device
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:243: drivers/perf/arm_pmu_acpi.o]
> Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [scripts/Makefile.build:480: drivers/perf] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [scripts/Makefile.build:480: drivers] Error 2
> make[1]: ***
> [/builddir/build/BUILD/kernel-6.5.8-rc1/linux-6.5.8-0.rc1.150.vanilla.fc37.aarch64/Makefile:2036:
> .] Error 2
> make: *** [Makefile:236: __sub-make] Error 2
> """
> 
> Full build log:
> https://copr-be.cloud.fedoraproject.org/results/@kernel-vanilla/stable-rc/fedora-37-aarch64/06529454-stablerc-stablerc-releases/builder-live.log.gz

Thanks, I'll drop the offending commit and push out a -rc2.

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel