Re: [PATCH v8 17/23] drm/mediatek: Support MT8188 Padding in display driver

Shawn Sung (宋孝謙)
2023-10-17T11:18:39Z

Hi Angelo,

On Tue, 2023-10-17 at 11:44 +0200, AngeloGioacchino Del Regno wrote:
> +static const struct of_device_id mtk_padding_driver_dt_match[] = {
> > + { .compatible = "mediatek,mt8188-padding" },
> > + { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, mtk_padding_driver_dt_match);
> > +
> > +struct platform_driver mtk_padding_driver = {
> > + .probe = mtk_padding_probe,
> > + .remove = mtk_padding_remove,
> > + .driver = {
> > + .name = "mediatek-padding",
>
> Please let's be consistent with the driver names, this should be
> "mediatek-disp-padding".
>
> After changing that,
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
>

Will change in the next version.

Thanks,
Shawn