From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 118D8CDB465 for ; Tue, 17 Oct 2023 01:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bY1r9fZ+rGnQW7dKlw1CWJtRkunWdGnfgRwI9PnVteY=; b=GGbEoIYCCQEfh9 8gNGPs2nVP+nkpuk1d+6w9J4nGmMyCG+Hlb5eNVdozC3ofLjeE9gMQYb4XkfqvNc3t5UboGEQBor9 6mdUhX/ipyhndMR4yK3fyK30B+pe8CJPnrTpF1oyjEj4MkAMwUHH7OU7cboMKQQVIaNeZdRPp2tP3 xk9u/mIkcDccI9mPG8sQppu30fli/bAGlzpe/Gq9XS+eEWYo/zG37OAqSitaiOGePbIz3RmPpd/oZ QTItgsB7MbO0hy+w4sDfgn8G41aDrzFaI52VGDkF5HzBc+z1PALwfzOxVYE522NHryyZ/1q01rOTc O3TsGoGLTDuvOg2pj6dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsYZt-00AyCI-35; Tue, 17 Oct 2023 01:08:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsYZp-00AyBP-1R for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 01:08:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AF85861219; Tue, 17 Oct 2023 01:08:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44F90C433C9; Tue, 17 Oct 2023 01:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697504931; bh=jHzMCQWvVZ1Q/xaW0hEOcnP75eSP2Fct28NmE+fM2ZA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U5Ejo6A7IGivJxgjcnLAn/xvYjhejkxSLLUq+ISYOO4hgxkafLCn8H+gOyRFR9rsj 55vPcR9PbV8r/+Zd/WmCmair8sw52RzbAswebcAHVUJIkQRHIyUZOcvGFurw1NBwzP 2JAxU9Vqf17EOx2wBwDek3hce2tEDODuGGZqtoU66waHayDQsR6TDUCUeKDXsnqI/N SOAkbqABIJJalva1wtuOOJmF47ALmc+tQa6XtvEjcfGLL1z9HVeA3XLCXs4iKQGyk0 wv2eH7UEqPfYDMNI2yZG5tvJdpuDjgey9j2Hyw3+P3kQ9uslM19cS17gS98qgKDfrq JF+g184XSUXjQ== Date: Mon, 16 Oct 2023 18:08:49 -0700 From: Jakub Kicinski To: Christian Marangi Cc: Raju Rangoju , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Ping-Ke Shih , Kalle Valo , Simon Horman , Daniel Borkmann , Jiri Pirko , Hangbin Liu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [net-next PATCH v3 3/4] net: stmmac: move TX timer arm after DMA enable Message-ID: <20231016180849.1cc29549@kernel.org> In-Reply-To: <20231014092954.1850-4-ansuelsmth@gmail.com> References: <20231014092954.1850-1-ansuelsmth@gmail.com> <20231014092954.1850-4-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231016_180853_533644_AA5BBA04 X-CRM114-Status: UNSURE ( 9.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 14 Oct 2023 11:29:53 +0200 Christian Marangi wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 5124ee87286c..240a18b97825 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -2545,7 +2545,8 @@ static void stmmac_bump_dma_threshold(struct stmmac_priv *priv, u32 chan) > * @queue: TX queue index > * Description: it reclaims the transmit resources after transmission completes. > */ > -static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue) > +static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue, > + bool *pending_packets) Missing kdoc for new param, build with W=1 catches this. -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel