From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEBB1CDB474 for ; Tue, 17 Oct 2023 15:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oeKHZ4Fno3nfkZ/ZTafu6366MfoXk4fQRj6VEcs/bYk=; b=wmRB7kw+aBTmYn uHmTsxQjokRA3PyBd99tGYDTd530V6cWckJU3enuo5SldmBlPl5o71Bx1MMEDTtkkSa14i4UYBvGx uxkCu+rDA7cUlTSmTvIbeUNanie99FWHNn8yxJimxnE+6mrjqyHnfVgEPwKNYePS23kbVN8TPWvRO O56PDJbrELEgmStpBNKkLW4zyXEkTZBtLG27/kWuDrIjb9KNgZC1L3Cqj+QbF2y6o3PVIzWHM5xD4 MalRhjSZkVTZHaBGDUtSd0UPSaGjVDjpAVgiR7427EK+jRDDkMvZrk4idyihB4w+GwA8L2+G5ybaL WFx/EPazJnrgjvy7D+zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qslks-00CiRX-1e; Tue, 17 Oct 2023 15:13:10 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qslkp-00CiQB-33; Tue, 17 Oct 2023 15:13:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5F5A8CE18BD; Tue, 17 Oct 2023 15:13:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ED79C433C8; Tue, 17 Oct 2023 15:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697555584; bh=JJc9uTY6VESHKtR5Rwh2zpqzChvYnI7TdKWdn6WPs14=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MXlNQibyA6fZX59FsDqAImWdfJ2ih+TXCnscodf3g8+R9omBLcX/s62+o+7WAuzU/ FICPLw0vFyVsL3tAaDzuf5HsyiBSc9j6Q5YgaDcyLt0VKOzF51lZpt5DnQOrIutWdA eotRndq9Lp3W+l0OUaWmHbOzcqWuZYUfNBBsQ05hbxUsYEwnKAzvQP0/2NDTc+k695 xShDcSzo2Bp+t8bIfyYhUxBLd4lbsbIuT1RTmCcDkVO6A++OL4IPUZ6q97npihxVXq 4kDcI2SMPSH6qdwZkopC/EGxghJNwo8hoUZ5vG4JfANfyvey4SUcj/kHOSxIPOLSUj Wt2lTDHetvlrA== Date: Tue, 17 Oct 2023 08:13:03 -0700 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , , , , Alexander Duyck Subject: Re: [PATCH net-next v11 0/6] introduce page_pool_alloc() related API Message-ID: <20231017081303.769e4fbe@kernel.org> In-Reply-To: <2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com> References: <20231013064827.61135-1-linyunsheng@huawei.com> <20231016182725.6aa5544f@kernel.org> <2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_081308_175722_89B383D6 X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Oct 2023 15:56:48 +0800 Yunsheng Lin wrote: > > And I can't figure out now what the "cache" in the name is referring to. > > Looks like these are just convenience wrappers which return VA instead > > of struct page.. > > Yes, it is corresponding to some API like napi_alloc_frag() returning va > instead of 'struct page' mentioned in patch 5. > > Anyway, naming is hard, any suggestion for a better naming is always > welcomed:) I'd just throw a _va (for virtual address) at the end. And not really mention it in the documentation. Plus the kdoc of the function should say that this is just a thin wrapper around other page pool APIs, and it's safe to mix it with other page pool APIs? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel