From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFAAFCDB474 for ; Tue, 17 Oct 2023 23:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VOOoLHBef6CMUgFo6Z2TpnQOyohe56lGFan8ZNXBhWo=; b=A4krEpuQzsJhHX vz7HAd/5a4cS9xvfKvMRw/xs9pUu25WKXM90IdBaGfPnqG3GaQVsjAbbY6+Hnv9sqo2RT6FMJ52/m RgPnolWatHjKn+wfAJImVYpIBpiYLoi+MHCgTg+h/Gmvr95jU3hr+oWmBX9E7DAYAmT12wgWkUw36 CEiq1/ULHXycjmpn0O1zm3Wovg8xRuIuj219bCm4dxn2/mWs0iRKalRIFwyD52nIry/3gp+BDFqcW UXUBDDaLC9tXBuRGtTs4hmBxUslXlZS8rcC7h6gJZJ78BjOci4zKEgYxh3mw0zST1afNAfTe/1jKw ZQ42Jdz/Bne25gqEQjzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qstpq-00DS6O-0m; Tue, 17 Oct 2023 23:50:50 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qstpm-00DS4p-2n for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 23:50:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D2659CE2255; Tue, 17 Oct 2023 23:50:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 104ADC433C7; Tue, 17 Oct 2023 23:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697586643; bh=DX4eQLbDH4WkaayNMxaAdYWcxQIc3Jkh/CQPfojaQEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OCbx8CfjXQDmgOK+IJZIpXLto/5Ledwx9z5n0guSGwzj4YeTet2MByosXF+VEl/wp qmzX/92ZHeZ7aX3X3PuDjXgoLqgaj36J1sVU5ESBfbRxfhb99DTacmhIG/E4YYmRQG IZ64NtUjRYNYda1jZo1oz1iRGrgia7TtQ8yBw4Rzo8o+UYZfeHdrymVvZuSuXbOOkU EKcYUfpWl4HbuRg/Y4DWEx+5IUqF98ANbnRmz0G8zEcIs82xvoQ8IZZhcgd14ILbXd Mg/lEa2uAginD05ObCUe9yLe7v8eHWpzhr63VADWExW27TmJ5PGz1j8CtaiRV++fJQ KNnsfUF2hZNxQ== Date: Tue, 17 Oct 2023 16:50:42 -0700 From: Jakub Kicinski To: Marc Kleine-Budde Cc: Johannes Zink , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Maxime Coquelin , netdev@vger.kernel.org, Richard Cochran , Kurt Kanzenbach , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, Eric Dumazet , Jose Abreu , Simon Horman , Paolo Abeni , "David S. Miller" , linux-arm-kernel@lists.infradead.org, patchwork-jzi@pengutronix.de Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Message-ID: <20231017165042.30fa9061@kernel.org> In-Reply-To: <20231017-transfer-refurbish-5cfaf12a524c-mkl@pengutronix.de> References: <20231010-stmmac_fix_auxiliary_event_capture-v1-0-3eeca9e844fa@pengutronix.de> <20231010-stmmac_fix_auxiliary_event_capture-v1-2-3eeca9e844fa@pengutronix.de> <20231014144428.GA1386676@kernel.org> <004d6ce9-7d15-4944-b31c-c9e628e7483a@pengutronix.de> <20231017082618.4558ad06@kernel.org> <20231017-transfer-refurbish-5cfaf12a524c-mkl@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_165047_083252_4EEADF0A X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Oct 2023 22:27:41 +0200 Marc Kleine-Budde wrote: > > Would be good to clarify what impact on device operation the problem > > has. How would end user notice the problem? > > Does it mean snapshots were always or never enabled, previously? > > On all dwmac devices not covered by dwmac-intel.c (INTEL 10/100/1000 > Ethernet PCI driver), PPS capture can be requested from user-space, but > is not enabled in HW. There is no error message or other feedback to the > user space. The user space will not get any PPS events. > > As this change also affects the Intel driver, and we don't have any > hardware to test, I think it's better that this goes via net-next to > give it a bit more time of testing. SGTM, we can chalk it up to "never worked, doesn't hurt anyone" and put it in net-next. But then the Fixes tag must go. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel