From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Umang Jain <umang.jain@ideasonboard.com>,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v2 1/3] staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE
Date: Wed, 18 Oct 2023 15:22:18 +0200 [thread overview]
Message-ID: <2023101803-blank-relative-aa47@gregkh> (raw)
In-Reply-To: <20231018123856.GG11118@pendragon.ideasonboard.com>
On Wed, Oct 18, 2023 at 03:38:56PM +0300, Laurent Pinchart wrote:
> On Wed, Oct 18, 2023 at 11:12:12AM +0530, Umang Jain wrote:
> > VC04 has now a independent bus vchiq_bus to register its devices.
> > However, the module auto-loading for bcm2835-audio and bcm2835-camera
> > currently happens through MODULE_ALIAS() macro specified explicitly.
> >
> > The correct way to auto-load a module, is when the alias is picked
> > out from MODULE_DEVICE_TABLE(). In order to get there, we need to
> > introduce vchiq_device_id and add relevant entries in file2alias.c
> > infrastructure so that aliases can be generated. This patch targets
> > adding vchiq_bus_device_id and do_vchiq_bus_entry, in order to
> > generate those alias using the /script/mod/file2alias.c.
> >
> > Going forward the MODULE_ALIAS() from bcm2835-camera and bcm2835-audio
> > will be dropped, in favour of MODULE_DEVICE_TABLE being used there.
> >
> > The alias format for vchiq_bus devices will be "vchiq_bus:<dev_name>".
> > Adjust the vchiq_bus_uevent() to reflect that.
>
> None of the other buses have a "_bus" suffix in the alias or in the
> *_device_id structure name. Is there a reason to make an exception here?
No, it should be dropped, good catch.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-18 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:42 [PATCH v2 0/3] vc04_services: Tweak module autoloading support Umang Jain
2023-10-18 5:42 ` [PATCH v2 1/3] staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE Umang Jain
2023-10-18 12:38 ` Laurent Pinchart
2023-10-18 13:22 ` Greg Kroah-Hartman [this message]
2023-10-18 5:42 ` [PATCH v2 2/3] staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS Umang Jain
2023-10-18 12:41 ` Laurent Pinchart
2023-10-18 5:42 ` [PATCH v2 3/3] staging: vc04_services: bcm2835-camera: " Umang Jain
2023-10-18 12:42 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101803-blank-relative-aa47@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).