From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C824ACDB47E for ; Wed, 18 Oct 2023 13:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K08X8qsbBcI+sN72sfjs5U3TMmNdEamh730rTg+4YKs=; b=0Kkh2tfqJ6uLAm IHxQqkPLX+qC73m7PZB/0gWdQce8AdawG8AwEQMa+O39dIqBhHbPT7iaVPoH2tuaOAO06AhuXmSOF MZMgeJ87eYvZV+MjtJtUjhEDUnP1WT45hv/Kylhzls72Ehpr0MBO0Rn1N+ghwilKUQyfKa5Ru8/+o AQ1PWnfTkqbc6w0m35qnE8Xarp2cO/2DVS5FFYHy7gAQD260dWCF6oSbXE6NsO6jZD96Vnfdk5rwN 84EtQ8W08r/U/QKgmJ3PKqQs9eX9P1xzAzm2dsAaYFvBR9H3VvcHPX1i+eRW1Nzfk12KoUiQoQCrn FFjckQpHbHqx9EVOxoQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt6VG-00ElbC-1m; Wed, 18 Oct 2023 13:22:26 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt6VD-00Elal-2j; Wed, 18 Oct 2023 13:22:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3EF0F617C5; Wed, 18 Oct 2023 13:22:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61BEBC433C8; Wed, 18 Oct 2023 13:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697635342; bh=8+Um29cxdKQH99k0YCMYU1lmGY+TvNwv0ssEVKJ1ujQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P++VYR7rtIcMPQDptRNHO/xcDdDJAAqe9fNh9/3YUa3XS1cOFIkiYMREZ+KQSwTsy YZzEW3UAUmfiohQGH7U3R8vyRYCHoKhih46E2htgtnoaVuCHoZT8LuVPOjklOHnzsB VwoVeBN9581zsUuL6fwRSHYUy5yfKqzCEKPKZiTk= Date: Wed, 18 Oct 2023 15:22:18 +0200 From: Greg Kroah-Hartman To: Laurent Pinchart Cc: Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham Subject: Re: [PATCH v2 1/3] staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE Message-ID: <2023101803-blank-relative-aa47@gregkh> References: <20231018054214.824296-1-umang.jain@ideasonboard.com> <20231018054214.824296-2-umang.jain@ideasonboard.com> <20231018123856.GG11118@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231018123856.GG11118@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_062223_960137_FECD3D8A X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 18, 2023 at 03:38:56PM +0300, Laurent Pinchart wrote: > On Wed, Oct 18, 2023 at 11:12:12AM +0530, Umang Jain wrote: > > VC04 has now a independent bus vchiq_bus to register its devices. > > However, the module auto-loading for bcm2835-audio and bcm2835-camera > > currently happens through MODULE_ALIAS() macro specified explicitly. > > > > The correct way to auto-load a module, is when the alias is picked > > out from MODULE_DEVICE_TABLE(). In order to get there, we need to > > introduce vchiq_device_id and add relevant entries in file2alias.c > > infrastructure so that aliases can be generated. This patch targets > > adding vchiq_bus_device_id and do_vchiq_bus_entry, in order to > > generate those alias using the /script/mod/file2alias.c. > > > > Going forward the MODULE_ALIAS() from bcm2835-camera and bcm2835-audio > > will be dropped, in favour of MODULE_DEVICE_TABLE being used there. > > > > The alias format for vchiq_bus devices will be "vchiq_bus:". > > Adjust the vchiq_bus_uevent() to reflect that. > > None of the other buses have a "_bus" suffix in the alias or in the > *_device_id structure name. Is there a reason to make an exception here? No, it should be dropped, good catch. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel