From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B222CDB482 for ; Wed, 18 Oct 2023 12:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3Zr3X97XopG2oh6hQJHJz0BF8EHX/Yk2jpLXAtEE/+g=; b=tj/Kh1bLfCexBe zFjFvmfcCdo2RPnAQH5WJ22o3IuDYUKKwAywQyLtEUmZLPwZMB614NpeigXR/lCMVepOH06uQV+0u nY+hby7fjP/zOIJ80eOU6LXmvadVrlIuc+po/FPDu1u1RBfrT2W9LzoRaiotKS67l6yWVJJ/BxTfW UHL4i2vFtmwkrRE7U8YROZz7Xef0m3CfJyy7N1aqRYfIcNczha+5K6smNfOza9gvFoE9ZL7MhXoaQ uQ5d4KuMeeFQ72kuKNZ8b8vNj6hTVOdSodFoMiRDKP2yJgWxyRUkXiReGihkaJfLqk1QDzRNzNDVV Od/DuMMqkF9slL3BaOGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt5rK-00EgpM-1r; Wed, 18 Oct 2023 12:41:10 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt5rI-00EgoO-15; Wed, 18 Oct 2023 12:41:09 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F6545AA; Wed, 18 Oct 2023 14:40:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697632859; bh=Abg4cWW/qvbpQ3j6SQ/yO305OVSh2VH6ub81c6y154c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mjDEledRj0dUARTZxnGhZTpLLu6KeBBUbkhMx+uiEXP8kKEgRqHUFdz0fk0rbOMD5 en0c90IKeYR1FJt5prJnPq/2UM81Mxn7Az8GvNz8F6dG5PQLebZWI/Ta0h/mZzQY3x wnahfPB6datT0LfDyYHZvgzHGG0A5jWSygI4NTyE= Date: Wed, 18 Oct 2023 15:41:13 +0300 From: Laurent Pinchart To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham Subject: Re: [PATCH v2 2/3] staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS Message-ID: <20231018124113.GH11118@pendragon.ideasonboard.com> References: <20231018054214.824296-1-umang.jain@ideasonboard.com> <20231018054214.824296-3-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231018054214.824296-3-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_054108_519602_F2A6ABD3 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Thank you for the patch. On Wed, Oct 18, 2023 at 11:12:13AM +0530, Umang Jain wrote: > Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module > alias should be dropped from there. > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c > index 06bdc7673d4b..d5bd8a36a010 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c > @@ -311,12 +311,19 @@ static int snd_bcm2835_alsa_resume(struct vchiq_device *device) > > #endif > > +static struct vchiq_bus_device_id device_id_table[] = { > + { .name = "bcm2835-audio" }, > + {} > +}; > +MODULE_DEVICE_TABLE(vchiq_bus, device_id_table); With the "_bus" suffix dropped (see review of 1/3), Reviewed-by: Laurent Pinchart > + > static struct vchiq_driver bcm2835_alsa_driver = { > .probe = snd_bcm2835_alsa_probe, > #ifdef CONFIG_PM > .suspend = snd_bcm2835_alsa_suspend, > .resume = snd_bcm2835_alsa_resume, > #endif > + .id_table = device_id_table, > .driver = { > .name = "bcm2835-audio", > }, > @@ -326,4 +333,3 @@ module_vchiq_driver(bcm2835_alsa_driver); > MODULE_AUTHOR("Dom Cobley"); > MODULE_DESCRIPTION("Alsa driver for BCM2835 chip"); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("bcm2835-audio"); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel