From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v2 3/3] staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS
Date: Wed, 18 Oct 2023 15:42:29 +0300 [thread overview]
Message-ID: <20231018124229.GI11118@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20231018054214.824296-4-umang.jain@ideasonboard.com>
Hi Umang,
Thank you for the patch.
On Wed, Oct 18, 2023 at 11:12:14AM +0530, Umang Jain wrote:
> Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module
> alias should be picked from there.
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> index c873eace1437..44901aab637b 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> @@ -1995,9 +1995,16 @@ static void bcm2835_mmal_remove(struct vchiq_device *device)
> vchiq_mmal_finalise(instance);
> }
>
> +static const struct vchiq_bus_device_id id_table[] = {
> + { .name = "bcm2835-camera" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(vchiq_bus, id_table);
With the "_bus" suffix dropped (see review of 1/3),
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> static struct vchiq_driver bcm2835_camera_driver = {
> .probe = bcm2835_mmal_probe,
> .remove = bcm2835_mmal_remove,
> + .id_table = id_table,
> .driver = {
> .name = "bcm2835-camera",
> },
> @@ -2008,4 +2015,3 @@ module_vchiq_driver(bcm2835_camera_driver)
> MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture");
> MODULE_AUTHOR("Vincent Sanders");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("bcm2835-camera");
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-18 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:42 [PATCH v2 0/3] vc04_services: Tweak module autoloading support Umang Jain
2023-10-18 5:42 ` [PATCH v2 1/3] staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE Umang Jain
2023-10-18 12:38 ` Laurent Pinchart
2023-10-18 13:22 ` Greg Kroah-Hartman
2023-10-18 5:42 ` [PATCH v2 2/3] staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS Umang Jain
2023-10-18 12:41 ` Laurent Pinchart
2023-10-18 5:42 ` [PATCH v2 3/3] staging: vc04_services: bcm2835-camera: " Umang Jain
2023-10-18 12:42 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018124229.GI11118@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).