From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D737CDB47E for ; Wed, 18 Oct 2023 12:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZGQwyciGTpXl3o66N11HbwWd3Aiiniq5oqfn6BGYLEc=; b=rkCiir+qtB/3cI IL39Q6FNK7kgUuHTXcJ1IBTlbdWVCKA+ckFGOWZHWMDxX01xIMiLBmx7iht3Cf0Xs9qXes5pfw5JP FegvvpP4R5ZH4OhFikoixOLsspm6NQFSMIN5iIcIkv7Y12C1xY+inH2lBu6F4kS0h/rCC0jzpIkC4 GfOxa3th3+WHkDAvzWeK+qWq35MpLkbRFP0oenIMF2q4or/kj0GnuQ+2ViIc6Q4RrhnjliW+PUJKR LvqTO0IbSsh3Kzosfg5Sd19l556WHHtAYmIiPXvY1yvj0gRcIldqNMeNCzRUf2h+/e6gFs4SNGNGY R7w8QjT1C1BYx+FSEspQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt5sX-00Eh3k-2e; Wed, 18 Oct 2023 12:42:25 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt5sV-00Eh2u-0g; Wed, 18 Oct 2023 12:42:24 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AAD0E5AA; Wed, 18 Oct 2023 14:42:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697632934; bh=E8xmvWGnV2lLRkEznHcs8rfnSSlzFrPMlF1rhf7ju6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ptXqlN5y+tKSGnr9pESprs48pV+FbLMNKlVlF9lf9l3uh7VDoJYCoUKpWx+u5iGY/ Gs3pU7fSwBMfM29qqHBBGtXvsALj7WhA5+0xnmJ1qw2w6hrPQWpe/B1Zp41oqymnbK oVQ/3CQpkLSqe8VLC271yxtPOy7bVzTDkxE2WENM= Date: Wed, 18 Oct 2023 15:42:29 +0300 From: Laurent Pinchart To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham Subject: Re: [PATCH v2 3/3] staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS Message-ID: <20231018124229.GI11118@pendragon.ideasonboard.com> References: <20231018054214.824296-1-umang.jain@ideasonboard.com> <20231018054214.824296-4-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231018054214.824296-4-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_054223_389209_D0F84FAF X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Thank you for the patch. On Wed, Oct 18, 2023 at 11:12:14AM +0530, Umang Jain wrote: > Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module > alias should be picked from there. > > Signed-off-by: Umang Jain > --- > .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > index c873eace1437..44901aab637b 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > @@ -1995,9 +1995,16 @@ static void bcm2835_mmal_remove(struct vchiq_device *device) > vchiq_mmal_finalise(instance); > } > > +static const struct vchiq_bus_device_id id_table[] = { > + { .name = "bcm2835-camera" }, > + {} > +}; > +MODULE_DEVICE_TABLE(vchiq_bus, id_table); With the "_bus" suffix dropped (see review of 1/3), Reviewed-by: Laurent Pinchart > + > static struct vchiq_driver bcm2835_camera_driver = { > .probe = bcm2835_mmal_probe, > .remove = bcm2835_mmal_remove, > + .id_table = id_table, > .driver = { > .name = "bcm2835-camera", > }, > @@ -2008,4 +2015,3 @@ module_vchiq_driver(bcm2835_camera_driver) > MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture"); > MODULE_AUTHOR("Vincent Sanders"); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("bcm2835-camera"); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel