From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCE35CDB482 for ; Thu, 19 Oct 2023 11:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7tEgSgXDnqdmU4GULOGzEBqPHjIyKrHrJacFZf4ty2s=; b=T6j8w6ySu4SAmcEKp4scDQUIi5 YY4U52nFjRN8gR8YnEExelxwx5kC2buXibCPOBAQux0xZP7hBBjFpUxv5GSBQ9dWu8W/25XJNOh6B doiZCaOwPUwJKsRC1cmwxpPLdEU3tyaksGRxoCyRW4dOTCkgLmbCPdqElo5V/wym95kOsHkRHSEKG MZzzoeHRKQWwdShN6wUGwv7XT68kZNRd0oFR0VnIbDkXQvdWnGaI09UcLKYExGPph0K7PjU/vuFSY FqlDcbkCWx8Kmc8aK2fVJieA0MxNF0xwc3lHekNM0EKEGc8txGv7rJLhLU9A99RVveRgIpl9/yFfM vcTHjTPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtRg2-00HEcU-15; Thu, 19 Oct 2023 11:58:58 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtRfy-00HEb4-2O for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 11:58:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 170EAB827D6; Thu, 19 Oct 2023 11:58:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5F70C433C7; Thu, 19 Oct 2023 11:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697716732; bh=pQ29kk3ro7C4ElFonv3EiTyV06E9AE6VC1caQ8VJxwM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BiHQUzkiiwPx41o8oTijdhqMqEXP1W25W/6P2gxP333hdS1fWElZGUXwcZOFKHvAE cmXg9p1vLYgAgLAP0tWcEU4XVlSaZtjlrl+jJV6sX4fFeL2/dYheIuuDxyReA2yPWK dmnnFSGr4MMGkrX6NWzxT6aimA2DsamgEPvcRhqZ8+AX+gWX0VK8IJ6GmEHVhjaGvb 4stUNkFTprB1mcaYGVqaR0HEx2Rhpqryf1F76igl+q5oeYNRQ0vAtdsKM5vxrnGxok yBgfszESwHukgx/1g2Or0UuShMbAsnnWlya4MgSz/uUxSpN1pg8AdDRYQmSl4ItAq5 cNlksfeV7wqbg== Date: Thu, 19 Oct 2023 12:58:46 +0100 From: Conor Dooley To: "Russell King (Oracle)" Cc: Linus Walleij , Rob Herring , Christian Marangi , Andrew Lunn , Florian Fainelli , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Conor Dooley , Sebastian Hesselbarth , Eric Dumazet , Vladimir Oltean , Rob Herring , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-kernel@vger.kernel.org, Gregory Clement Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Message-ID: <20231019-pulse-autopilot-166bb6c96090@spud> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-1-3ee0c67383be@linaro.org> <169762516670.391804.7528295251386913602.robh@kernel.org> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_045855_066357_55BC0ABA X-CRM114-Status: GOOD ( 24.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6744045039289045160==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6744045039289045160== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y6vV29njl6hI4/69" Content-Disposition: inline --Y6vV29njl6hI4/69 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 19, 2023 at 11:58:49AM +0100, Russell King (Oracle) wrote: > On Wed, Oct 18, 2023 at 01:11:45PM +0200, Linus Walleij wrote: > > On Wed, Oct 18, 2023 at 12:32=E2=80=AFPM Rob Herring = wrote: > > > On Wed, 18 Oct 2023 11:03:40 +0200, Linus Walleij wrote: > >=20 > > > > Bindings using dsa.yaml#/$defs/ethernet-ports specify that > > > > a DSA switch node need to have a ports or ethernet-ports > > > > subnode, and that is actually required, so add requirements > > > > using oneOf. > > > > > > > > Suggested-by: Rob Herring > > > > Signed-off-by: Linus Walleij > > > > --- > > > > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_ch= eck' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:7: [warning] = wrong indentation: expected 8 but found 6 (indentation) > > > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:7: [warning] = wrong indentation: expected 8 but found 6 (indentation) > >=20 > > Really? > >=20 > > + oneOf: > > + - required: > > + - ports > > + - required: > > + - ethernet-ports > >=20 > > Two spaces after the oneOf, 2 spaces after a required as usual. > > I don't get it. >=20 > Given the other python errors spat out in Rob's report, I would suggest > that the "bot" is running a development version that hasn't been fully > tested, so anything it spits out is suspect. Maybe Rob can comment on > the validity of the warnings in the report. In this case, I think it is correct. 2 spaces for the oneOf, 2 spaces the start of the required for the nested list, so: oneOf: - required: - ports - required: - ethernet-ports --Y6vV29njl6hI4/69 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTEZ9gAKCRB4tDGHoIJi 0iD0AP9nnypeoKCSb5p1jYVtkd/GxlHX1dmnIRWn/6opBLMHGQD+IqlWgD04icVW jyfkLzfNK6BmN32rgviaunCpTobjLAY= =HyDl -----END PGP SIGNATURE----- --Y6vV29njl6hI4/69-- --===============6744045039289045160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6744045039289045160==--