From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25C36CDB483 for ; Thu, 19 Oct 2023 14:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1JI4A8yISkTMj80R2n529qNVIRA2/5dwbuQGr90fWNM=; b=rMlp+nzinACJs4 dbJZ9LsMhFkcf38oKFiZhZpB1p+szKUEjXvjpLMHkE6Q6YxYq9Pc9q+suT8uQkQ8o8KrNKktfdYs6 +iOBdKSgA+UzqS2vkj+/rlOSJbFLd0WoMEQr0RRNH36K3/Rtz8/xeOg//PV2z9yz1UeCDDLjzpAHn 5MgReNbfrbfz79BMysB9sCl+kl/zdOY8l8xH6ffTflKiIN6ctiLlWCEmL+wVtSCuIHDmlKNl7XBeq MQFtEIwkFw4cYxKlFT38C8xoI0TCVu56IKv9hXonuhJGck01+N6IMeJbX0/Ww7O/cw2lMcNz5Odfr BUxtdnQy77IK+LhYvNUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtU2J-0004Qz-1N; Thu, 19 Oct 2023 14:30:07 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtU2H-0004P1-0E for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 14:30:06 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9ba081173a3so1321763266b.1 for ; Thu, 19 Oct 2023 07:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697725802; x=1698330602; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wX4f50XOLEee00Srtb8FwAKFIgUc/Wj/C0qtW/ywJag=; b=JWRygZHjWAdgESIRgdmQImu0iqoVlyLfzU0Wkc8Xe10M7Y3VcJQKE5t7plxhLbwLKi OymOSvgwjIqbHJldUa/kDcOckhGT0eNvZJmCW+dyin5hJoHpgPEGfjXqqPyiEJwFFkEL npPVmtwafnQU5eSAUN5C5NV7mLxM3T9NgSXCajcTDayVABgf61RdPjtT22heod51Pl3Y pbbCrC8qbVtCznQa6Xe5FxVogArHCw6XQMssyDD9d+9tdZPatwJdgxZWd59/yXurjv5z ir7n3cd72LcPnYeNLq44A8Ono/Vh9QXsc4DNZOBmG1tQkghcL+qxgH0GjKu3y66cyJf5 9u/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697725802; x=1698330602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wX4f50XOLEee00Srtb8FwAKFIgUc/Wj/C0qtW/ywJag=; b=cJ8ou95Awecm1QLsDTfHl6MR86rjfeZuvXVJ4HuGnvlRelOxGLhKvOrJo8xtiAeDoj cUarQ0lSnWba0mLEAtbtIx1dcpjtDUuLGpBbNhXuz8Qk0VlKMHfEFrUXGVTxTs3Fmzyo KrvotRSODgVRBxIhfSO0dfd19wNnC0Eb4zj2rmq9XGmFNQotFOcF4J9zBzMQZqoBLCHh x18pqfTan4TwViMiURI9FL6JJ1vJBArYe+aKqZiBHMLUtF8jSdDzCYNls8SYHLYK0u8S wPoG4SMhX8EbVsvmk8hNoq/S0v3Dggu3ITmECG6tsxSWiDSqvitbwM525SZWaq8IkuMy PYfA== X-Gm-Message-State: AOJu0YyHNeXL+XXc0kdHO9L+HR5r4k9SB1hD6O6MCYxDI5KtTtStaEvz V14maIxspbmCcxzoUq0JkWQ= X-Google-Smtp-Source: AGHT+IFsJj8OuUADqu+SUI3NdXBcemhuiA1k26KFrGqr30sspr3z516YCjG0rPLm7A45IR+YTKJIBA== X-Received: by 2002:a17:907:7e94:b0:9bf:10f3:e435 with SMTP id qb20-20020a1709077e9400b009bf10f3e435mr2237055ejc.1.1697725802098; Thu, 19 Oct 2023 07:30:02 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id g4-20020a170906594400b009c7558b39fasm2427690ejr.194.2023.10.19.07.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 07:30:01 -0700 (PDT) Date: Thu, 19 Oct 2023 17:29:59 +0300 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Linus Walleij , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v4 3/7] ARM: dts: marvell: Fix some common switch mistakes Message-ID: <20231019142959.qonrf6cfqoxe7uun@skbuf> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-3-3ee0c67383be@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_073005_112696_60440D50 X-CRM114-Status: GOOD ( 21.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 19, 2023 at 12:04:46PM +0100, Russell King (Oracle) wrote: > On Wed, Oct 18, 2023 at 11:03:42AM +0200, Linus Walleij wrote: > > Fix some errors in the Marvell MV88E6xxx switch descriptions: > > - The top node had no address size or cells. > > - switch0@0 is not OK, should be switch@0. > > - The ports node should have port@0 etc children, no > > plural "ports". > > > > This serves as an example of fixes needed for introducing a > > schema for the bindings, but the patch can simply be applied. > > In patch 2, you mention that things should be named ethernet-switch and > ethernet-port. As you're renaming the nodes in this patch, wouldn't it > make sense to use those names instead now, rather than at some point in > the future a patch that converts to these names? I agree, and I was wondering the same thing. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel