From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCF67CDB483 for ; Thu, 19 Oct 2023 14:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U66XaSsHL4X78lGW6gcwihbhxj0c9YgYAkpGBFyRmU0=; b=Rdr49qTtVMVXMX /k1Co/LusDZOVqzf/RK6gWq3vGESqGm3iTZ5MybG1eo9cWpX+AO1PvTUk/W+6Qe9GmNc1UtRCqBoU GnJnjtTS0ACYiZ4q5H2H6Sg9uPZ1EvMBIz03Q7oTR+T26AFyMk6DNCLMWXMzMBGciaivdd1riKAe2 oEVhEVLe4NYJ7gk99KZgjheq+rl/rdljBhe5GbladKu4m8w35+N0UvxTfyTYm602jRTbiJTS3jDev NB7Q+oYMIT8md3nZl4bJ2rFGpXd4ON5mCBUCdnAmtGvnsKeh9O1msKaJBRsDmaAXzT/St0g+Uz0BO y2/+5cCOnoRCzC0NCPMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtUCL-00066V-0s; Thu, 19 Oct 2023 14:40:29 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtUCJ-00065h-0E for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 14:40:28 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-991c786369cso1291504766b.1 for ; Thu, 19 Oct 2023 07:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697726425; x=1698331225; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XSY+Q3S/YK4XQIguVFEmoJaZjehN9Q5LV7SrMSM6K5E=; b=aZ9rari3fDy8JTgM+n6h5M38TG5bx1BqLKea2gPMTykYpnVncrJhD654wKYFZ3vZP2 reUr92jHvepU6yZJWSMd4/79gipSQfT/bntDrlDy9ZowHeEeI2M8Bnp15gYNCriwBBjl HpjtRjzOY0x+9zr2sk5ikCzD88r1drkW8GjLuRHbQsUQkNmwspDwt3RPseSqhDiCcwRI kShEchEdmPkSkPqHC4eFmem42Y65rEr1T57uTNFuZkuq7GQBL1s09Fj508YI9prFUYVL iWmQJZHVeG7UeyXZRdWttKV6BaxxdLmYXQpbzQsdV+hhYsj9VBPTKmfeSojty8f9BVJb aYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697726425; x=1698331225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XSY+Q3S/YK4XQIguVFEmoJaZjehN9Q5LV7SrMSM6K5E=; b=UNwZKTPsPwy/b1V/zUsv8hhRBgcgq6aGPsukzqtXPirywxmFnt1gMjXgSMvxyJxn3M uvs0fC1X+tg6J6dgQlRaRh9qDsg/d6R4L1bi8Q4FVNrlY+5EinGXROVvqlVqTKRtqAm4 QNvwFBEdV4ihdWdg2Lfz7Q6yuyuDBLrb6TvREyBBaGOzQbJGOD/EcWGRzPXhCw9oNK/G EZ/HTGFUjJ7wywLzsxEdsDLY/D1WuBnFRa1hgdlg5HXXbyxiP41gmEAsGyWQK7P5A+oq QekWIBdRVq0huIB2MjAjx3grzOCPV1JLpb3179vMAO0BItJEw92aUoPYDnlar6Q7Hrrb uRlw== X-Gm-Message-State: AOJu0YyFB2wmA7cL97Qrzz+TxhaCe1eSg4y/Gq1ow6g1VxaCaQKI/Hk6 2QUqcul25LCki+RW5ZNr0ds= X-Google-Smtp-Source: AGHT+IGETJBV9QkBTzlB91U/LGkd1pwzRiYAwX9szZp/irOUJNFYyLtBZCx7Ha1SVm9x9XzwDU443A== X-Received: by 2002:a17:907:7d90:b0:9bd:f031:37b6 with SMTP id oz16-20020a1709077d9000b009bdf03137b6mr1864380ejc.49.1697726424599; Thu, 19 Oct 2023 07:40:24 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id hx10-20020a170906846a00b009a13fdc139fsm3652625ejc.183.2023.10.19.07.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 07:40:24 -0700 (PDT) Date: Thu, 19 Oct 2023 17:40:22 +0300 From: Vladimir Oltean To: Linus Walleij , Marek =?utf-8?B?QmVow7pu?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v4 5/7] ARM64: dts: marvell: Fix some common switch mistakes Message-ID: <20231019144021.ksymhjpvawv42vhj@skbuf> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-5-3ee0c67383be@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231018-marvell-88e6152-wan-led-v4-5-3ee0c67383be@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_074027_110379_7E013294 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Marek On Wed, Oct 18, 2023 at 11:03:44AM +0200, Linus Walleij wrote: > Fix some errors in the Marvell MV88E6xxx switch descriptions: > - The top node had no address size or cells. > - switch0@0 is not OK, should be switch@0. > > Signed-off-by: Linus Walleij > --- > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 9eab2bb22134..c69cb4e191e5 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -305,7 +305,7 @@ phy1: ethernet-phy@1 { > }; > > /* switch nodes are enabled by U-Boot if modules are present */ > - switch0@10 { > + switch@10 { As the comment says: U-Boot (https://elixir.bootlin.com/u-boot/latest/source/board/CZ.NIC/turris_mox/turris_mox.c#L728) sets up status = "okay" for these nodes depending on the MOXTET configuration. It doesn't look as if it's doing that by alias, just by path ("%s/switch%i@%x"). I have a Turris MOX, please allow me some time to test if the node name change is going to be significant and cause regressions. I expect the answer to be yes (sadly). > compatible = "marvell,mv88e6190"; > reg = <0x10>; > dsa,member = <0 0>; > @@ -430,7 +430,7 @@ port-sfp@a { > }; > }; > > - switch0@2 { > + switch@2 { > compatible = "marvell,mv88e6085"; > reg = <0x2>; > dsa,member = <0 0>; > @@ -497,7 +497,7 @@ port@5 { > }; > }; > > - switch1@11 { > + switch@11 { > compatible = "marvell,mv88e6190"; > reg = <0x11>; > dsa,member = <0 1>; > @@ -622,7 +622,7 @@ port-sfp@a { > }; > }; > > - switch1@2 { > + switch@2 { > compatible = "marvell,mv88e6085"; > reg = <0x2>; > dsa,member = <0 1>; > @@ -689,7 +689,7 @@ port@5 { > }; > }; > > - switch2@12 { > + switch@12 { > compatible = "marvell,mv88e6190"; > reg = <0x12>; > dsa,member = <0 2>; > @@ -805,7 +805,7 @@ port-sfp@a { > }; > }; > > - switch2@2 { > + switch@2 { > compatible = "marvell,mv88e6085"; > reg = <0x2>; > dsa,member = <0 2>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel