From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 408A1CDB483 for ; Thu, 19 Oct 2023 14:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JoTnoRJTlZsQYSk0vsp3AAv8FYsCr1R6OvRfVzLYtvI=; b=0yhzJGCJ5fBeJ3 jRm2XnmAjOcJPIXymlQyMY+A1YWU9ndG48wbkq3PHNbC18b+egInhNkqWggVbw8Sd8CAdk72Q5wpd Rm2r/2PEuGdfp+vEHTU7xMylMS4e7KLJQnkBClkNCHNUz9e0bsfxqhtBI9oL+gntgDy5VZF7PbaC6 PecMe6d9lu8r7XEs+ZeichayVMFQW256PuC2sjanMShvQ1rPFoGq6gK1pjCvJm9j2Q5bv/RNOEb6A DTm4jWHEeR0LykFNaNkUQB8JqHkpQgdmE6meYPfvUiXz3u8MsCKalAmbxzzdidu3BM+GQKjdsld2D CnIn78UejN6WsFMUS5LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtULH-00080a-01; Thu, 19 Oct 2023 14:49:43 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtULE-0007zp-1H for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 14:49:42 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9c2a0725825so769455766b.2 for ; Thu, 19 Oct 2023 07:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697726979; x=1698331779; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1UrROzncfUZarmm/TSy/yEjSWVF3nSkzcxEecGv20ms=; b=Q8ptC23TKKgNm5AC7kAGV5U2euYQxNAalPJ9+H94++6giPJHqiD+xOaq4nFMVgJhIO pgVZA46N2z3TXC4B9kv7EQoq5xPb5QuwWit+ZbmBhsVoSU/N8+UU5PITMGCy6f6h82/C A2gZJbnjbCIp8nLC8lrHz/atH0jEOCFLER71OnYA7AVCbHcLRkupXUjoXEZGAJQaxUG3 8Qkh7RTOVgmPRKk3MnAxxB6tiXnbAj9+xh80XzkTm2EeJ1L6fmkXfJa6kUcshU4tpQhk BcmGDOsOaPPvFEhBHKTKRqL4OlSf0Wc/IlEGsl5P7lXAJqY9YDb5ixseZAb9C3QYzg20 6k+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697726979; x=1698331779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1UrROzncfUZarmm/TSy/yEjSWVF3nSkzcxEecGv20ms=; b=YJ79sXK6ZE2Et9LMaySmQq8uCbAU8SDtPmKJRpjJvoyS3XtMFsFabV+uTibycnyH+A g8ffSh7Wg0IMqMwp9vIBcB0FKBxeOx8+6Lcnq9gLOnRpQRZdr6LBzRSePb6wUmaH0xzo zMpay2cyvGhHlo/WfmRxhdhl51Hqy7S3INvMxRxA7nFt1IBJ7sU5Muz19/naJeD+bv3D S7DqRK2PE6IuAQI6WCSR7FMK+PwpnPAL9TlJC5TG6eoi1zXqkzv9I54wgvZ9d07O0HrU J1LY2gA3dsmcDhdWOyKeuG1XgnUaKfMwYyJhgzGY9C8Sx3X1Oo165LQTqCgp+SDWPrUX q5PA== X-Gm-Message-State: AOJu0YxOIPlmJv/PTOiN4sUv9r1rjJPNRgsI3y3oR/Z/jLbm3qbXUsfZ XvNh7bTx98EmdrYhVDig1as= X-Google-Smtp-Source: AGHT+IEikpJiGCrfEciG/A1zcBBKrzN+hrLe/h7mhbzpCNe9XJuqFeUVwUwqnJukEn/D2p0KFDhUNg== X-Received: by 2002:a17:907:6eac:b0:9bf:792:d696 with SMTP id sh44-20020a1709076eac00b009bf0792d696mr2261658ejc.46.1697726977896; Thu, 19 Oct 2023 07:49:37 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id h3-20020a1709063b4300b009b9aa8fffdasm3654934ejf.131.2023.10.19.07.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 07:49:37 -0700 (PDT) Date: Thu, 19 Oct 2023 17:49:35 +0300 From: Vladimir Oltean To: Linus Walleij , Marek =?utf-8?B?QmVow7pu?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v4 5/7] ARM64: dts: marvell: Fix some common switch mistakes Message-ID: <20231019144935.3wrnqyipiq3vkxb7@skbuf> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-5-3ee0c67383be@linaro.org> <20231019144021.ksymhjpvawv42vhj@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231019144021.ksymhjpvawv42vhj@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_074940_436359_185B22BD X-CRM114-Status: GOOD ( 24.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 19, 2023 at 05:40:22PM +0300, Vladimir Oltean wrote: > +Marek > > On Wed, Oct 18, 2023 at 11:03:44AM +0200, Linus Walleij wrote: > > Fix some errors in the Marvell MV88E6xxx switch descriptions: > > - The top node had no address size or cells. > > - switch0@0 is not OK, should be switch@0. > > > > Signed-off-by: Linus Walleij > > --- > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > index 9eab2bb22134..c69cb4e191e5 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > @@ -305,7 +305,7 @@ phy1: ethernet-phy@1 { > > }; > > > > /* switch nodes are enabled by U-Boot if modules are present */ > > - switch0@10 { > > + switch@10 { > > As the comment says: U-Boot > (https://elixir.bootlin.com/u-boot/latest/source/board/CZ.NIC/turris_mox/turris_mox.c#L728) > sets up status = "okay" for these nodes depending on the MOXTET > configuration. It doesn't look as if it's doing that by alias, just by > path ("%s/switch%i@%x"). > > I have a Turris MOX, please allow me some time to test if the node name > change is going to be significant and cause regressions. I expect the > answer to be yes (sadly). Yeah, it's bad. U-Boot 2018.11 (Dec 16 2018 - 12:50:19 +0000), Build: jenkins-turris-os-packages-kittens-mox-90 DRAM: 1 GiB Enabling Armada 3720 wComphy-0: SGMII1 3.125 Gbps Comphy-1: PEX0 5 Gbps Comphy-2: USB3_HOST0 5 Gbps MMC: sdhci@d8000: 0 Loading Environment from SPI Flash... SF: Detected w25q64dw with page size 256 Bytes, erase size 4 KiB, total 8 MiB OK Model: CZ.NIC Turris Mox Board Net: eth0: neta@30000 Turris Mox: Board version: 22 RAM size: 1024 MiB SD/eMMC version: SD Module Topology: 1: Peridot Switch Module (8-port) 2: Peridot Switch Module (8-port) 3: Peridot Switch Module (8-port) 4: SFP Module Hit any key to stop autoboot: 0 => run sd_tftp_boot neta@30000 Waiting for PHY auto negotiation to complete....... done BOOTP broadcast 1 BOOTP broadcast 2 DHCP client bound to address 10.0.0.117 (254 ms) Using neta@30000 device TFTP from server 10.0.0.1; our IP address is 10.0.0.117 Filename 'mox/armada-3720-turris-mox.dtb'. Load address: 0x4f00000 Loading: #### 1.5 MiB/s done Bytes transferred = 19479 (4c17 hex) Using neta@30000 device TFTP from server 10.0.0.1; our IP address is 10.0.0.117 Filename 'mox/Image'. Load address: 0x5000000 Loading: ################################################################# ########################################## 6 MiB/s done Bytes transferred = 54069760 (3390a00 hex) ## Flattened Device Tree blob at 04f00000 Booting using the fdt blob at 0x4f00000 Loading Device Tree to 000000003bf16000, end 000000003bf1dc16 ... OK ERROR: board-specific fdt fixup failed: FDT_ERR_NOTFOUND - must RESET the board to recover. FDT creation failed! hanging...### ERROR ### Please RESET the board ### _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel