From: Raag Jadav <raag.jadav@intel.com>
To: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, mark.rutland@arm.com,
will@kernel.org, linux@roeck-us.net
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v1 3/8] ACPI: sysfs: use acpi_device_uid() for fetching _UID
Date: Fri, 20 Oct 2023 14:17:27 +0530 [thread overview]
Message-ID: <20231020084732.17130-4-raag.jadav@intel.com> (raw)
In-Reply-To: <20231020084732.17130-1-raag.jadav@intel.com>
Convert manual _UID references to use standard ACPI helpers.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/acpi/device_sysfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index b9bbf0746199..9d8e90744cb5 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -410,7 +410,7 @@ static ssize_t uid_show(struct device *dev,
{
struct acpi_device *acpi_dev = to_acpi_device(dev);
- return sprintf(buf, "%s\n", acpi_dev->pnp.unique_id);
+ return sprintf(buf, "%s\n", acpi_device_uid(acpi_dev));
}
static DEVICE_ATTR_RO(uid);
@@ -554,7 +554,7 @@ int acpi_device_setup_files(struct acpi_device *dev)
if (dev->pnp.type.bus_address)
result = device_create_file(&dev->dev, &dev_attr_adr);
- if (dev->pnp.unique_id)
+ if (acpi_device_uid(dev))
result = device_create_file(&dev->dev, &dev_attr_uid);
if (acpi_has_method(dev->handle, "_SUN")) {
@@ -635,7 +635,7 @@ void acpi_device_remove_files(struct acpi_device *dev)
if (acpi_has_method(dev->handle, "_HRV"))
device_remove_file(&dev->dev, &dev_attr_hrv);
- if (dev->pnp.unique_id)
+ if (acpi_device_uid(dev))
device_remove_file(&dev->dev, &dev_attr_uid);
if (dev->pnp.type.bus_address)
device_remove_file(&dev->dev, &dev_attr_adr);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-20 8:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 8:47 [PATCH v1 0/8] Refine _UID references across kernel Raag Jadav
2023-10-20 8:47 ` [PATCH v1 1/8] ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-20 10:35 ` Andy Shevchenko
2023-10-20 15:49 ` Jonathan Cameron
2023-10-20 8:47 ` [PATCH v1 2/8] pinctrl: intel: use " Raag Jadav
2023-10-20 8:47 ` Raag Jadav [this message]
2023-10-20 17:18 ` [PATCH v1 3/8] ACPI: sysfs: use acpi_device_uid() for fetching _UID Rafael J. Wysocki
2023-10-20 8:47 ` [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-20 10:36 ` Andy Shevchenko
2023-10-20 11:38 ` Raag Jadav
2023-10-20 13:42 ` Andy Shevchenko
2023-10-20 14:00 ` Raag Jadav
2023-10-20 17:11 ` Rafael J. Wysocki
2023-10-20 18:11 ` Raag Jadav
2023-10-21 6:51 ` Raag Jadav
2023-10-20 8:47 ` [PATCH v1 5/8] ACPI: x86: " Raag Jadav
2023-10-20 10:37 ` Andy Shevchenko
2023-10-20 17:05 ` Rafael J. Wysocki
2023-10-20 18:42 ` Andy Shevchenko
2023-10-20 8:47 ` [PATCH v1 6/8] perf: qcom: use acpi_device_uid() for fetching _UID Raag Jadav
2023-10-20 17:22 ` Rafael J. Wysocki
2023-10-20 8:47 ` [PATCH v1 7/8] hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and _UID Raag Jadav
2023-10-20 8:47 ` [PATCH v1 8/8] perf: arm_cspmu: " Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020084732.17130-4-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).